Date: Tue, 1 Dec 2009 10:28:40 -0800 From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> To: Matthias Drochner <m.drochner@googlemail.com> Cc: freebsd-bluetooth@freebsd.org, plunky@netbsd.org Subject: Re: patch to make obexapp work with BSD iconv(3) Message-ID: <bb4a86c70912011028m1c595d03r6d04ce29f7aca632@mail.gmail.com> In-Reply-To: <20091201125054.44a00147@zelz27> References: <20091201125054.44a00147@zelz27>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthias, > Here is a patch which removes the GNU iconv dependency from obexapp. > I've successfully tested it by sending vcards with strange names; > the resulting files were identical. thanks for the patch! could you please tell me which bsd flavor you tested this on? > The relevant changes are: > -just use the result of nl_langinfo(CODESET) as input of > iconv_open(3), this is more robust than trying to interpret > the locale string > -remove iconvctl(ICONV_SET_DISCARD_ILSEQ) -- BSD doesn't > have this and it should be unneeded because it only > compensates for some non-standard behaviour of GNU iconv. > (The bsdxml->expat part is unrelated.) i dont really have any objections to those, just wanted to get some clarification. thanks max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70912011028m1c595d03r6d04ce29f7aca632>