Date: Sat, 10 May 2003 00:31:15 +0200 (CEST) From: Lukas Ertl <l.ertl@univie.ac.at> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: freebsd-fs@freebsd.org Subject: Re: newfs: useless/bogus check if new last block can be accessed? Message-ID: <20030510002107.T638@korben.in.tern> In-Reply-To: <15149.1052518679@critter.freebsd.dk> References: <15149.1052518679@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 10 May 2003, Poul-Henning Kamp wrote: > In message <20030510000438.Y638@korben.in.tern>, Lukas Ertl writes: > > >> syv# newfs -s 2049 md5 > >> newfs: /dev/md5: maximum file system size is 2048 > >> syv# > > > >But since this size check comes much earlier in the code, I guess the > >wtfs() call is useless and should be removed, shouldn't it? > > If the check still works, I'd tend to keep it on the basis that it > does no harm, but if you tell me that it would never result in an > error, then we might as well remove it. I don't think it does any harm to keep it (WRT to getting a working filesystem), but since I don't see how it would signal an error (and this is why I posted the question) I'd vote for removing the check. And while we're here: shouldn't wtfs() actually give a return value and not be just static void? (In terms of: "be a good programmer and check the return values of your syscalls...") I think it's called often enough in newfs to qualify for a check :-) regards, le --=20 Lukas Ertl eMail: l.ertl@univie.ac.at UNIX-Systemadministrator Tel.: (+43 1) 4277-14073 Zentraler Informatikdienst (ZID) Fax.: (+43 1) 4277-9140 der Universit=E4t Wien http://mailbox.univie.ac.at/~le/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030510002107.T638>