Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Jun 2000 14:27:43 -0700
From:      Alfred Perlstein <bright@wintelcom.net>
To:        Jonathan Lemon <jlemon@flugsvamp.com>
Cc:        arch@FreeBSD.ORG
Subject:   Re: accept filters
Message-ID:  <20000618142743.G18462@fw.wintelcom.net>
In-Reply-To: <20000618162502.A619@prism.flugsvamp.com>; from jlemon@flugsvamp.com on Sun, Jun 18, 2000 at 04:25:02PM -0500
References:  <20000618140412.F18462@fw.wintelcom.net> <20000618162502.A619@prism.flugsvamp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
* Jonathan Lemon <jlemon@flugsvamp.com> [000618 14:20] wrote:
> On Sun, Jun 18, 2000 at 02:04:12PM -0700, Alfred Perlstein wrote:
> > http://people.freebsd.org/~alfred/accf.diff
> 
> This part I somewhat dislike:
> 
>  struct socket {
>         struct  vm_zone *so_zone;       /* zone we were allocated from */
>         short   so_type;                /* generic type, see socket.h */
> @@ -112,6 +114,9 @@
>         /* NB: generation count must not be first; easiest to make it last. */
>         so_gen_t so_gencnt;             /* generation count */
>         void    *so_emuldata;           /* private data for emulators */
> +       struct  accept_filter *so_accept_filter;
> +       void    *so_accept_filter_arg;  /* saved filter args */
> +       char    *so_accept_filter_str;  /* saved user args */
>  };
> 
> Isn't there a better way of doing this than adding more elements
> to every socket?  Especially since this only applies to listen()
> sockets?

I could make it just one pointer to a struct that holds all three?

Or I can take out the passing of arguments to accept filters, but
I thought otherwise people would complain that it isn't
bloated^H^H^H^H^H^H^Hmodular enough.  And it would also annoy me
because it was difficult to do...

-- 
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
"I have the heart of a child; I keep it in a jar on my desk."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000618142743.G18462>