Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 May 2002 01:47:48 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   RE: cvs commit: src/sys/alpha/include atomic.h
Message-ID:  <XFMail.20020517014748.jhb@FreeBSD.org>
In-Reply-To: <200205170545.g4H5jdd33910@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 17-May-2002 John Baldwin wrote:
> jhb         2002/05/16 22:45:39 PDT
> 
>   Modified files:
>     sys/alpha/include    atomic.h 
>   Log:
>   - Apparently, the Alpha ABI mandates that arguments be passed sign-extended
>     regardless of if they are signed or unsigned since it is easier to work
>     with sign-extended values.  Thus, remove the disabled zapnot to
>     zero-extend the sign-extended value we read from *p in atomic_cmpset_32()
>     since the cmpval we are comparing against should already be
>     sign-extended.
>   - To ensure that the compiler knows to sign-extend the upper 32 bits of
>     cmpval rather than leaving garbage in there, cast the appropriately in
>     the constraints section.
>   
>   Help from:      Richard Henderson <rth@redhat.com>

According to Richard, the fact that 2.95 zero-extended the value was a bug.

Oops. :-P

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020517014748.jhb>