Date: Mon, 28 Jun 2010 16:35:36 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: "M. Warner Losh" <imp@bsdimp.com> Cc: yanefbsd@gmail.com, freebsd-current@freebsd.org, pjd@freebsd.org, hselasky@c2i.net Subject: Re: Patch for rc.d/devd on FreeBSD 9-current Message-ID: <86pqzb5io7.fsf@ds4.des.no> In-Reply-To: <20100628.081810.502133560696912792.imp@bsdimp.com> (M. Warner Losh's message of "Mon, 28 Jun 2010 08:18:10 -0600 (MDT)") References: <AANLkTikI223vbyBdEqLuA6FjcBBeQcqFujOimP5horsv@mail.gmail.com> <20100627.201716.1108826596298620201.imp@bsdimp.com> <86iq537egy.fsf@ds4.des.no> <20100628.081810.502133560696912792.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"M. Warner Losh" <imp@bsdimp.com> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > "M. Warner Losh" <imp@bsdimp.com> writes: > > > Maybe the real problem is that devd locks the file, then dies. The > > > file remains locked, so the flopen is failing with EWOULDBLOCK. > > The lock is released when the process that holds it terminates. > So which process is that? devd took it out, and is subsequently > killed. When it restarts, it can't take out the lock. What does fstat say about the pid file? > The same code works perfectly in 8.0-stable from April. > > The conclusion, I believe, is that somebody broke locking in > current... Before I wrote one of my earlier replies, I traced through the code paths that lead to a lock being released, and everything looks fine and dandy. Besides, if someone had, as you suggest, broken locking in current, there would be a lot more noise about it on the lists. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86pqzb5io7.fsf>