Date: Tue, 26 Jun 2001 08:24:13 +0200 (CEST) From: Luigi Rizzo <luigi@info.iet.unipi.it> To: FastPathNow@netscape.net Cc: freebsd-net@FreeBSD.ORG Subject: Re: TCPS_HAVERCVDFIN not considering all possible conditions? Message-ID: <200106260624.IAA94869@info.iet.unipi.it> In-Reply-To: <45D08C2C.558913DD.375A6AF3@netscape.net> from "FastPathNow@netscape.net" at "Jun 25, 2001 09:11:45 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
this macro suggests that it would be better to define tcp states as a set of individual bits, so one does not have to do arithmetics on state IDs. cheers luigi > Currently in tcp_fsm.h its defined as : > #define TCPS_HAVERCVDFIN(s) ((s) >= TCPS_TIME_WAIT) > > when IMHO it should be: (to consider all possible cases of having recd a FIN?) > > #define TCPS_HAVERCVDFIN(s) ( ((s) >= TCPS_TIME_WAIT) || ((s) == TCPS_CLOSE_WAIT) || ((s) == TCPS_LAST_ACK) || ((s) == TCPS_CLOSING) ) > > -AG > > __________________________________________________________________ > Get your own FREE, personal Netscape Webmail account today at http://webmail.netscape.com/ > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-net" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106260624.IAA94869>