Date: Mon, 22 Dec 2008 12:15:45 -0800 From: "Garrett Cooper" <yanefbsd@gmail.com> To: "Antoine Brodin" <antoine@freebsd.org> Cc: Ed Schouten <ed@80386.nl>, Roman Divacky <rdivacky@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Norikatsu Shigemura <nork@freebsd.org> Subject: Re: Change select(2) to kevent(2) on script(1)... Message-ID: <7d6fde3d0812221215t24b401e9ue180bc915d16d92c@mail.gmail.com> In-Reply-To: <f19c444a0812220759i44707666oc91e25cda225d75b@mail.gmail.com> References: <20081221012752.cdc5cbfc.nork@FreeBSD.org> <20081221211949.GS1176@hoeg.nl> <20081222091203.GA28920@freebsd.org> <494F740E.3040502@FreeBSD.org> <20081223002901.9b71e60d.nork@FreeBSD.org> <f19c444a0812220759i44707666oc91e25cda225d75b@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/22/08, Antoine Brodin <antoine@freebsd.org> wrote: > On Mon, Dec 22, 2008 at 4:29 PM, Norikatsu Shigemura <nork@freebsd.org> > wrote: >> I think that performance improvement is significant(I don't >> think performance improved by my patch). But my patch is the >> first implementation of kqueue/kevent support for TTY. >> In fact, I could find a bug. I hope to commit my patch. But >> by performance reason, my patch is not accepted, I have no >> problem. > > Hi, > > Could you make it a compile time option, similar to the USE_KQUEUE > option in make(1) ? > I had to write something similar to script(1) for work recently, that > ran on linux, and the freebsd sources were quite useful. > > Cheers, > > Antoine Would partitioning out the select(2) code and #ifdef'ing it to mux between the kevent(2) and select(2) interfaces be a prudent measure to follow? The select(2) interface is essentially fixed now, so unless POSIX changes that section of code shouldn't change. Any and all advancements forward could be using the kevent(2) method, as long as it's time permitting and the win / cost ratio is sufficiently high enough to warrant it. The fun part will be regression testing -_-. -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d0812221215t24b401e9ue180bc915d16d92c>