Date: Tue, 4 Apr 2000 03:07:59 +0800 From: Adrian Chadd <adrian@freebsd.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, current@FreeBSD.ORG Subject: Re: 2nd call for reviews and tests: buf->bio patch Message-ID: <20000404030757.A53939@ewok.creative.net.au> In-Reply-To: <200004031751.KAA60287@apollo.backplane.com>; from Matthew Dillon on Mon, Apr 03, 2000 at 10:51:49AM -0700 References: <22448.954783492@critter.freebsd.dk> <200004031751.KAA60287@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 03, 2000, Matthew Dillon wrote: > > : > : > :Matt, > : > :When I mailed arch@ about this change I got no response from anybody > :but Bruce. > : > :I talked to Kirk about it in Malmø and got his approval. > : > :This is not unplanned. > : > :This is also not untested, I have two complete prototypes behind me. > : > :It is regretable that vinum was broken, and I hope that it is fixed > :with Alfreds changes, one can't win 100% all the time. > : > :Your time would be more productively used by reviewing and testing > :the patch at http://phk.freebsd.dk/misc than by preaching. > : > :As to the debugging of the malloc/free issue in vinum, Sørens suggestion > :to use releng4 sounds downright sensible to me, and I suggest you do > :that. > : > :-- > :Poul-Henning Kamp FreeBSD coreteam member > > I don't think these excuses come close to justifying your commits > or your timing. * His timing did suck * He's now doing the right thing, at least, instead of committing the second patchset without submitting them for peer review * breaking vinum did suck * RELENG_4 is a good place to play with vinum fixes too * You both have committed things that have broken other areas. :-) This really isn't constructive. I haven't looked at the patchset that phk has posted up but I think it'd be more useful if people gave comments about the changes and their usefulness rather than the bickering going on now. Please :) Adrian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000404030757.A53939>