Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Mar 2001 22:52:52 -0700
From:      Warner Losh <imp@harmony.village.org>
To:        "Mario Sergio Fujikawa Ferreira" <lioux@uol.com.br>
Cc:        Maxim Sobolev <sobomax@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: CVSROOT modules ports/graphics Makefile 
Message-ID:  <200103140552.f2E5qq910055@harmony.village.org>
In-Reply-To: Your message of "Tue, 13 Mar 2001 23:26:02 -0300." <20010313232602.A6090@Fedaykin.here> 
References:  <20010313232602.A6090@Fedaykin.here>  <200103132140.f2DLebm86277@freefall.freebsd.org> <200103132150.f2DLoak14082@vic.sabbo.net> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20010313232602.A6090@Fedaykin.here> "Mario Sergio Fujikawa Ferreira" writes:
: 	What about some guidelines for commit verbosity? Specially
: for newcommers.

Generally, here's what I've seen done:

	o Simple changes for simple reasons get short messages.
	o New versions of ports describe what's different about the port
	  on FreeBSD with a pointer to what changed from the last
	  version.
	o Port checksum changes have a description of the old/new
	  tarball diffs.
	o Simple changes for complex reasons get longer messages
	o Complex changes get anywhere from a simple to complex
	  answer depending on the whim of the committer.
	o When you can use a pointer to other persistent
	  locations, do that (eg MFC 1.23, PR 12342), but only
	  when they are project controlled or likely to be around for
	  at least 5-10 years (cvs version, pr,  RFC, ansi
	  standard, etc).
	o Don't be needlessly verbose, nor overly cryptic.

Warner

P.S.  Feel free to turn this into a section in the handbook if you
want.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103140552.f2E5qq910055>