Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 08 Sep 2001 14:52:54 -0700
From:      Peter Wemm <peter@wemm.org>
To:        Josef Karthauser <joe@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: CVSROOT cfg.pm commit_prep.pl 
Message-ID:  <20010908215254.D8BCD380A@overcee.netplex.com.au>
In-Reply-To: <200109080211.f882BZt86733@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Josef Karthauser wrote:
> joe         2001/09/07 19:11:35 PDT
> 
>   Modified files:
>     .                    cfg.pm commit_prep.pl 
>   Log:
>   Add code to unexpand $FreeBSD: xxxx $ (or whatever is defined in
>   the config file as being our $IDHEADER$) upon commit.  This is useful
>   to avoid a '+1 -1' delta against the version string.

This is broken, it happens before the $Id$ spamming checks.  You only
want this to be run after all the sanity checks are done.  Of course then
you have to fix all the return's from the function. :-)

In fact, it should probably go after the &check_version() call, not
inside check_version itself.

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010908215254.D8BCD380A>