Date: Sat, 6 Jan 2007 15:40:30 +0100 From: Divacky Roman <xdivac02@stud.fit.vutbr.cz> To: John Baldwin <jhb@freebsd.org> Cc: Roman Divacky <rdivacky@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 112535 for review Message-ID: <20070106144030.GB1353@stud.fit.vutbr.cz> In-Reply-To: <200701051232.28019.jhb@freebsd.org> References: <200701050802.l0582Gnq067583@repoman.freebsd.org> <200701051232.28019.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 05, 2007 at 12:32:27PM -0500, John Baldwin wrote: > On Friday 05 January 2007 03:02, Roman Divacky wrote: > > http://perforce.freebsd.org/chv.cgi?CH=112535 > > > > Change 112535 by rdivacky@rdivacky_witten on 2007/01/05 08:01:24 > > > > No need to lock prison in a case of linux_use26 becuase the int > > setting is atomic and process cannot leave jail. > > > > Submitted by: kib > > Reviewed by: jhb > > > > Affected files ... > > > > .. //depot/projects/linuxolator/src/sys/compat/linux/linux_mib.c#6 edit > > > > Differences ... > > > > ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_mib.c#6 > (text+ko) ==== > > > > @@ -237,12 +237,10 @@ > > > > pr = td->td_ucred->cr_prison; > > if (pr != NULL) { > > - mtx_lock(&pr->pr_mtx); > > if (pr->pr_linux != NULL) { > > lpr = (struct linux_prison *)pr->pr_linux; > > use26 = lpr->pr_use_linux26; > > } > > - mtx_unlock(&pr->pr_mtx); > > } else > > use26 = linux_use_linux26; > > > > > > Hmm, what is use26 set to if pr != NULL but pr->pr_linux == NULL? to the default value of 0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070106144030.GB1353>