Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 1 Jul 2008 08:51:28 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Andre Oppermann <andre@freebsd.org>
Cc:        freebsd-net@freebsd.org, Paul <paul@gtcomm.net>, "Bruce M. Simpson" <bms@freebsd.org>, Mike Tancsa <mike@sentex.net>
Subject:   Re: Route messages
Message-ID:  <20080701084933.W57089@maildrop.int.zabbadoz.net>
In-Reply-To: <4869EC1E.8060009@freebsd.org>
References:  <4852E23E.2040505@gtcomm.net> <4854EBF1.7020708@FreeBSD.org> <l68b649csbvpf6l1ud32atuhq80rr3gsvj@4ax.com> <200807010606.m6166jFe084204@lava.sentex.ca> <4869EC1E.8060009@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 1 Jul 2008, Andre Oppermann wrote:

Hi,

> Mike Tancsa wrote:
>> I am thinking
>> 
>> http://lists.freebsd.org/pipermail/cvs-src/2008-April/090303.html
>> is the commit ? If I revert to the prev version, the issue goes away.

Ha, I finally know why I ended up on Cc: of a thread I had no idea
about. Someone could have told me instead of blindly adding me;-)


> Yes, this change doesn't look right.  It should only do the route
> lookup in ip_input.c when there was an EMSGSIZE error returned by
> ip_output().  The rtalloc_ign() call causes the message to be sent
> because it always sets report to one.  The default message is RTM_MISS.
>
> I'll try to prep an updated patch which doesn't have these issues later
> today.

Yeah my bad. Sorry.

If you do that, do not do an extra route lookup if possible, correct
the rtalloc call. Thanks.


Bjoern

-- 
Bjoern A. Zeeb              Stop bit received. Insert coin for new game.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080701084933.W57089>