Date: Mon, 20 Apr 2009 16:02:19 +0200 From: Roman Divacky <rdivacky@freebsd.org> To: "Simon 'corecode' Schubert" <corecode@fs.ei.tum.de> Cc: hackers@freebsd.org Subject: Re: [PATCH]: today highlighting in [n]cal Message-ID: <20090420140219.GA74839@freebsd.org> In-Reply-To: <49EC3E96.50208@fs.ei.tum.de> References: <20090420084118.GA16337@freebsd.org> <49EC3E96.50208@fs.ei.tum.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 20, 2009 at 11:21:26AM +0200, Simon 'corecode' Schubert wrote:
> Hey Roman,
>
> Roman Divacky wrote:
> >I made this patch that highlights today in cal/ncal just like gnu
> >cal does..
> >
> > www.vlakno.cz/~rdivacky/cal.patch
>
> Thanks for this patch, I've been meaning to hack one up properly, but
> never got to it. They problems I was facing seem to exist also with your
> patch:
>
> - only works for wide (cal) mode, not ncal mode
> - probably won't work properly with year displays: the year printing
> parts of the code use a length argument to printf ("%*s"), which will
> confuse escape sequences with actual printed characters
after addressing Simon's concerns here's a new patch:
www.vlakno.cz/~rdivacky/cal2.patch
this disables the highlighting for year printing because it's broken
and introduces the highlighting to ncal as well...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090420140219.GA74839>