Date: Mon, 20 Apr 2009 18:24:11 +0200 From: Alexey Shuvaev <shuvaev@physik.uni-wuerzburg.de> To: Roman Divacky <rdivacky@freebsd.org> Cc: hackers@freebsd.org Subject: Re: [PATCH]: today highlighting in [n]cal Message-ID: <20090420162411.GA50951@wep4035.physik.uni-wuerzburg.de> In-Reply-To: <20090420140219.GA74839@freebsd.org> References: <20090420084118.GA16337@freebsd.org> <49EC3E96.50208@fs.ei.tum.de> <20090420140219.GA74839@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 20, 2009 at 04:02:19PM +0200, Roman Divacky wrote:
> On Mon, Apr 20, 2009 at 11:21:26AM +0200, Simon 'corecode' Schubert wrote:
> > Hey Roman,
> >
> > Roman Divacky wrote:
> > >I made this patch that highlights today in cal/ncal just like gnu
> > >cal does..
> > >
> > > www.vlakno.cz/~rdivacky/cal.patch
> >
> > Thanks for this patch, I've been meaning to hack one up properly, but
> > never got to it. They problems I was facing seem to exist also with your
> > patch:
> >
> > - only works for wide (cal) mode, not ncal mode
> > - probably won't work properly with year displays: the year printing
> > parts of the code use a length argument to printf ("%*s"), which will
> > confuse escape sequences with actual printed characters
>
> after addressing Simon's concerns here's a new patch:
>
> www.vlakno.cz/~rdivacky/cal2.patch
>
> this disables the highlighting for year printing because it's broken
> and introduces the highlighting to ncal as well...
>
Nice!
It depends on one more lib now:
Modified:
~> ldd /usr/bin/ncal
/usr/bin/ncal:
libcalendar.so.4 => /usr/lib/libcalendar.so.4 (0x800643000)
libncurses.so.7 => /lib/libncurses.so.7 (0x800745000)
libc.so.7 => /lib/libc.so.7 (0x80088f000)
Old:
~> ldd /home/jails/kde4/usr/bin/ncal
/home/jails/kde4/usr/bin/ncal:
libcalendar.so.4 => /usr/lib/libcalendar.so.4 (0x800642000)
libc.so.7 => /lib/libc.so.7 (0x800744000)
Does it work good in single user mode?
(Don't want to go to it right now myself).
OTOH, who needs cal/ncal in single user mode? :)
Just my 0.02$,
Alexey.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090420162411.GA50951>