Date: Sat, 5 Nov 2011 17:15:31 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: mdf@freebsd.org Cc: "K. Macy" <kmacy@freebsd.org>, Alan Cox <alc@rice.edu>, Andriy Gapon <avg@freebsd.org>, freebsd-current@freebsd.org, Benjamin Kaduk <kaduk@mit.edu>, Penta Upa <bsdboot@gmail.com> Subject: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3] Message-ID: <20111105151530.GX50300@deviant.kiev.zoral.com.ua> In-Reply-To: <CAMBSHm86TaJnRRgmPA_t7tiPfQsPyoTqz3ymdHSY1H3t5G864Q@mail.gmail.com> References: <4EB22938.4050803@rice.edu> <20111103132437.GV50300@deviant.kiev.zoral.com.ua> <4EB2D48E.1030102@rice.edu> <20111104100828.GG50300@deviant.kiev.zoral.com.ua> <4EB40015.5040100@rice.edu> <20111104153004.GK50300@deviant.kiev.zoral.com.ua> <4EB4095D.3030303@rice.edu> <20111104160339.GM50300@deviant.kiev.zoral.com.ua> <20111105141306.GW50300@deviant.kiev.zoral.com.ua> <CAMBSHm86TaJnRRgmPA_t7tiPfQsPyoTqz3ymdHSY1H3t5G864Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--ps88Q+2tj/fdI4QF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 05, 2011 at 07:37:48AM -0700, mdf@freebsd.org wrote: > On Sat, Nov 5, 2011 at 7:13 AM, Kostik Belousov <kostikbel@gmail.com> wro= te: > > On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: > > > > Below is the KBI patch after vm_page_bits_t merge is done. > > Again, I did not spent time converting all in-tree consumers > > from the (potentially) loadable modules to the new KPI until it > > is agreed upon. >=20 > I like my bikeshed orange... >=20 > I would think a more canonical name would be get/set rather than > read/write, especially since these operations aren't reading and > writing the page (neither are they getting the page, but at least set > is pretty unambiguous). Look at the vm_page.h:385. vm_page_set_valid() is already taken. --ps88Q+2tj/fdI4QF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk61UxIACgkQC3+MBN1Mb4j/NwCgmgjqknOevgh+k6Wd/BYhlGLu RwAAoLi7w0iLGDgf50R8hrKiB/aZe2W8 =PzM2 -----END PGP SIGNATURE----- --ps88Q+2tj/fdI4QF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111105151530.GX50300>