Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Nov 2012 15:45:10 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Andre Oppermann <andre@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, svn-src-user@FreeBSD.org
Subject:   Re: svn commit: r243215 - user/andre/tcp_workqueue/sys/sys
Message-ID:  <20121119114510.GQ38060@FreeBSD.org>
In-Reply-To: <201211181217.qAICH7aH021497@svn.freebsd.org>
References:  <201211181217.qAICH7aH021497@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 18, 2012 at 12:17:07PM +0000, Andre Oppermann wrote:
A> Author: andre
A> Date: Sun Nov 18 12:17:07 2012
A> New Revision: 243215
A> URL: http://svnweb.freebsd.org/changeset/base/243215
A> 
A> Log:
A>   Add mtodo(m, o, t) macro taking an additional offset into
A>   the mbuf data section before the casting to type 't'.

IMHO, argument order of (m, t, o) is more intuitive, since
matches order of mtod().

A> 
A> Modified:
A>   user/andre/tcp_workqueue/sys/sys/mbuf.h
A> 
A> Modified: user/andre/tcp_workqueue/sys/sys/mbuf.h
A> ==============================================================================
A> --- user/andre/tcp_workqueue/sys/sys/mbuf.h	Sun Nov 18 12:16:50 2012	(r243214)
A> +++ user/andre/tcp_workqueue/sys/sys/mbuf.h	Sun Nov 18 12:17:07 2012	(r243215)
A> @@ -64,8 +64,10 @@
A>   * type:
A>   *
A>   * mtod(m, t)	-- Convert mbuf pointer to data pointer of correct type.
A> + * mtodo(m, o, t) - Same as above but with offset 'o' into data.
A>   */
A>  #define	mtod(m, t)	((t)((m)->m_data))
A> +#define	mtodo(m, o, t)	((t)(((m)->m_data) + (o)))
A>  
A>  /*
A>   * Argument structure passed to UMA routines during mbuf and packet

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121119114510.GQ38060>