Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Jun 2006 12:44:40 -0700
From:      Jason Evans <jasone@FreeBSD.org>
To:        Dan Lukes <dan@obluda.cz>
Cc:        freebsd-security@freebsd.org, Giorgos Keramidas <keramida@freebsd.org>
Subject:   Re: memory pages nulling when releasing
Message-ID:  <44985028.6020901@FreeBSD.org>
In-Reply-To: <44984A25.8060001@obluda.cz>
References:  <20060618203903.31161.qmail@web30306.mail.mud.yahoo.com> <44967861.6070509@obluda.cz> <20060620125350.10d0c9ef.nick@nickwithers.com> <44980ECC.5000607@obluda.cz> <20060620170353.GB90842@gothmog.pc> <449833DD.70904@FreeBSD.org> <44984A25.8060001@obluda.cz>

next in thread | previous in thread | raw e-mail | index | archive | help
Dan Lukes wrote:
> Jason Evans napsal/wrote, On 06/20/06 19:43:
> 
>>>> BTW, Z nor J doesn't imply 'R' despite of text of manual page.
> 
>> The man page looks accurate to me.  What aspect of the descriptions of 
>> 'J' and 'Z' do you think is incorrect?
> 
>     From manual page:
>  =======================
> J       ...
>     This options also sets the ``R'' option.
>     ...
> Z       This option implicitly sets the ``J'' and ``R'' options,
>  =======================
> 
>     From libc/stdlib/malloc.c (the lines containing malloc_realloc + 
> some lines around)
>  =======================
> static int malloc_realloc;
> ...
>         case 'r': malloc_realloc = 0; break;
>         case 'R': malloc_realloc = 1; break;
>         case 'j': malloc_junk    = 0; break;
> ...
>         if (!malloc_realloc &&             /* Unless we have to, */
>       size <= osize &&             /* .. or are too small, ...
>     if (!malloc_realloc &&        /* Unless we have to, */
>       size <= osize &&         /* ..or are too small, */
>  =======================
> 
>     The  malloc_realloc seems to be set on one place only - when R/r 
> present. Then it is used only. I see no dependency to J nor Z
> 
>     I send no PR because I have submitted several more important PR's 
> which are untouched for months. I don't want to overload committers nor 
> PR database.

Ah, this is for RELENG_6.  I had assumed you were talking about 
-current.  I agree with you that the man page is inaccurate for 
RELENG_6.  I don't currently use RELENG_6 for development though, so I'd 
recommend submitting a PR with a patch assigned to the docs folks if you 
want it fixed.  In my experience they are very responsive where man page 
accuracy is concerned.

Jason



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44985028.6020901>