Date: Thu, 9 Jan 2014 15:42:39 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <julio@meroh.net> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, "sjg@freebsd.org" <sjg@freebsd.org> Subject: Re: Fixing installation of Kyuafiles Message-ID: <68CF4BF2-E97F-4B5E-920E-854FD6BCA083@gmail.com> In-Reply-To: <20140109233402.GA8193@fbair.virtual.network> References: <20140109233402.GA8193@fbair.virtual.network>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 9, 2014, at 15:34, Julio Merino <julio@meroh.net> wrote:
>=20
> Hello,
>=20
> The bin/sh and bin/test tests are broken because they cannot be run as roo=
t,
> yet the testing machines are currently running stuff as root. This is eas=
y
> to fix by adding a require_user=3D"unprivileged" property to the tests.
>=20
> I was going to fix this by adding manually-crafted Kyuafile files that do
> the above in bin/sh/tests/ and bin/test/tests/ and setting KYUAFILE=3Dyes i=
n
> the corresponding Makefile files... but unfortunately that does not work
> with NO_CLEAN builds.
>=20
> The problem is that bsd.test.mk generates Kyuafile files in the obj direct=
ory
> and setting KYUAFILE=3Dyes means that make will _still_ see the Kyuafile i=
n the
> obj directory and not the one that just appeared in src.
>=20
> Does the attached patch seem reasonable to prevent this in the future?
>=20
> The patch does not fix current build trees with NO_CLEAN, but because
> WITH_TESTS is not yet the default I don't think it's a big deal.
>=20
> Thank you.
> <kyuafiles.diff>
Why not use ${.TARGET} instead of Kyuafile.auto?=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?68CF4BF2-E97F-4B5E-920E-854FD6BCA083>