Date: Mon, 19 Nov 2001 17:00:51 -0500 (EST) From: "Andrew R. Reiter" <arr@FreeBSD.org> To: Yar Tikhiy <yar@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/ftpd ftpd.c Message-ID: <Pine.NEB.3.96L.1011119165508.75141B-100000@fledge.watson.org> In-Reply-To: <200111192152.fAJLq3N94389@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 19 Nov 2001, Yar Tikhiy wrote: :yar 2001/11/19 13:52:03 PST : : Modified files: : libexec/ftpd ftpd.c : Log: : Eliminate another instance of the old and well-known : DoS bug that the select(2)/accept(2) pair is called on : a socket that is in the blocking I/O mode. The bug is : triggered if a selected connection dies before the accept(2) : leading to the accept(2) blocking virtually forever. : : MFC after: 1 week : : Revision Changes Path : 1.87 +25 -7 src/libexec/ftpd/ftpd.c Just as a thought, since I've noted the ftpd mucking, there are two issues with the ftp daemon code that are not necesarily critical, but should be changed: - Dynamically allocate the fd_set bit arrays - Correct usage of signal handlers to only use set/check flags. Got anymore motivation to tackle those? Cheers, Andrew -- Andrew R. Reiter arr@watson.org arr@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1011119165508.75141B-100000>