Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Dec 2001 09:37:10 +0100
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        The Anarcat <anarcat@anarcat.dyndns.org>
Cc:        arch@FreeBSD.ORG, jkh@FreeBSD.ORG
Subject:   Re: sysctl kern.disks shouldn't have to sort its output 
Message-ID:  <61270.1009096630@critter.freebsd.dk>
In-Reply-To: Your message of "Sat, 22 Dec 2001 18:08:00 EST." <20011222230759.GD530@shall.anarcat.dyndns.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20011222230759.GD530@shall.anarcat.dyndns.org>, The Anarcat writes:

>-- snip --
>revision 1.50.2.14
>date: 2001/09/18 06:47:30;  author: jkh;  state: Exp;  lines: +2 -2
>Temporarily disable the use of kern.disks - it returns the disk
>devices in the wrong order and causes them to be displayed out of
>sequence in sysinstall.


>To me, the sorting belongs to libdisk at most, or to the user app.

ABSOLUTELY!

>Of course, one might wonder why the entries in kern.disks are not
>sorted. This, I do not know. It might depend on how the disks are
>detected. For example, here, sysctl kern.disks gives:
>
>kern.disks: cd0 ad3 ad1 ad0 md0

The reason they are not sorted is that if userland wants them sorted,
it can be trivially done, whereas nothing in the kernel wants them
sorted and consequently sorting them in the kernel would be waste
of time&space.

Not to mention agreeing on what the _right_ sorting order would be:
	disk before CD/DVD ?
	SCSI before ATA ?
	Fixed before removable ?
	BIKESHED!!!!

>Anyways. If the sorting belongs to the kernel, I could do it.

don't.

>However, I think it belongs to libdisk, so I'll start working on a patch
>there.

Yes, please do.  That is what Jordan should have done (and was urged to)
in the first place, but he was afraid that he would b0rk sysinstall doing
so.  Go figure.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?61270.1009096630>