Date: Mon, 28 Apr 2003 18:07:46 +0200 (CEST) From: Harti Brandt <brandt@fokus.fraunhofer.de> To: freebsd-atm@freebsd.org Subject: Small patch for review Message-ID: <20030428142022.E931@beagle.fokus.fraunhofer.de>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-227327898-1051546066=:931 Content-Type: TEXT/PLAIN; charset=US-ASCII Hi, attached is a simple patch that does the following: - add a version number to net/if_atmsubr.c (just like if_ethersubr.c does) - add module dependency information to the en(4) driver - add a sysctl node hw.atm where the drivers will attach their hardware sysctl sub-trees - create an atm_ifdetach() function - make atm_ifattach() call if_attach (like ether_ifattach does) - remove the call to if_attach() from the en(4) driver The last two change the ABI, but this is not problem. The only other NATM driver (besides en) is an old LANAI driver floating on the net, that will anyway not work under current. So better to make the interface clean now, than later when there are more drivers. Is there something fundamentally wrong with this patch? harti -- harti brandt, http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.fraunhofer.de, harti@freebsd.org --0-227327898-1051546066=:931 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="atm.diff" Content-Transfer-Encoding: BASE64 Content-ID: <20030428180746.J931@beagle.fokus.fraunhofer.de> Content-Description: Content-Disposition: attachment; filename="atm.diff" SW5kZXg6IHN5cy9kZXYvZW4vbWlkd2F5LmMNCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0NClJDUyBmaWxlOiAvZXhwb3J0L2N2cy9mcmVlYnNkL3NyYy9zeXMv ZGV2L2VuL21pZHdheS5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4zNw0K ZGlmZiAtdSAtcjEuMzcgbWlkd2F5LmMNCi0tLSBzeXMvZGV2L2VuL21pZHdh eS5jCTI1IEFwciAyMDAzIDE2OjE0OjAzIC0wMDAwCTEuMzcNCisrKyBzeXMv ZGV2L2VuL21pZHdheS5jCTI4IEFwciAyMDAzIDE1OjUyOjMzIC0wMDAwDQpA QCAtMTczLDcgKzE3Myw3IEBADQogI2RlZmluZSBFTk9USEVSX0RSQUlOCTB4 MDIJCS8qIGFsbW9zdCBmcmVlIChkcmFpbiBEUlEgZG1hKSAqLw0KICNkZWZp bmUgRU5PVEhFUl9TV1NMCTB4MDgJCS8qIGluIHNvZnR3YXJlIHNlcnZpY2Ug bGlzdCAqLw0KIA0KLVNZU0NUTF9OT0RFKF9odywgT0lEX0FVVE8sIGVuLCBD VExGTEFHX1JXLCAwLCAiRU5JIDE1NXAiKTsNCitTWVNDVExfREVDTChfaHdf YXRtKTsNCiANCiAvKg0KICAqIGRtYSB0YWJsZXMNCkBAIC0yNzY3LDcgKzI3 NjcsNyBAQA0KIAlzeXNjdGxfY3R4X2luaXQoJnNjLT5zeXNjdGxfY3R4KTsN CiANCiAJaWYgKChzYy0+c3lzY3RsX3RyZWUgPSBTWVNDVExfQUREX05PREUo JnNjLT5zeXNjdGxfY3R4LA0KLQkgICAgU1lTQ1RMX1NUQVRJQ19DSElMRFJF TihfaHdfZW4pLCBPSURfQVVUTywNCisJICAgIFNZU0NUTF9TVEFUSUNfQ0hJ TERSRU4oX2h3X2F0bSksIE9JRF9BVVRPLA0KIAkgICAgZGV2aWNlX2dldF9u YW1ldW5pdChzYy0+ZGV2KSwgQ1RMRkxBR19SRCwgMCwgIiIpKSA9PSBOVUxM KQ0KIAkJZ290byBmYWlsOw0KIA0KQEAgLTI4NzcsNyArMjg3Nyw2IEBADQog CS8qDQogCSAqIGZpbmFsIGNvbW1pdA0KIAkgKi8NCi0JaWZfYXR0YWNoKGlm cCk7DQogCWF0bV9pZmF0dGFjaChpZnApOyANCiANCiAjaWZkZWYgRU5BQkxF X0JQRg0KSW5kZXg6IHN5cy9uZXQvaWZfYXRtLmgNCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0NClJDUyBmaWxlOiAvZXhwb3J0L2N2cy9mcmVlYnNkL3NyYy9z eXMvbmV0L2lmX2F0bS5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS42DQpk aWZmIC11IC1yMS42IGlmX2F0bS5oDQotLS0gc3lzL25ldC9pZl9hdG0uaAkx MyBNYXIgMjAwMyAxMjo0NDowNiAtMDAwMAkxLjYNCisrKyBzeXMvbmV0L2lm X2F0bS5oCTI4IEFwciAyMDAzIDE1OjUyOjQ4IC0wMDAwDQpAQCAtOTksNiAr OTksNyBAQA0KIA0KICNpZmRlZiBfS0VSTkVMDQogdm9pZAlhdG1faWZhdHRh Y2goc3RydWN0IGlmbmV0ICopOw0KK3ZvaWQJYXRtX2lmZGV0YWNoKHN0cnVj dCBpZm5ldCAqKTsNCiB2b2lkCWF0bV9pbnB1dChzdHJ1Y3QgaWZuZXQgKiwg c3RydWN0IGF0bV9wc2V1ZG9oZHIgKiwNCiAJCXN0cnVjdCBtYnVmICosIHZv aWQgKik7DQogaW50CWF0bV9vdXRwdXQoc3RydWN0IGlmbmV0ICosIHN0cnVj dCBtYnVmICosIHN0cnVjdCBzb2NrYWRkciAqLCANCkluZGV4OiBzeXMvbmV0 L2lmX2F0bXN1YnIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp bGU6IC9leHBvcnQvY3ZzL2ZyZWVic2Qvc3JjL3N5cy9uZXQvaWZfYXRtc3Vi ci5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4yNA0KZGlmZiAtdSAtcjEu MjQgaWZfYXRtc3Vici5jDQotLS0gc3lzL25ldC9pZl9hdG1zdWJyLmMJMTMg TWFyIDIwMDMgMTI6NDQ6MDYgLTAwMDAJMS4yNA0KKysrIHN5cy9uZXQvaWZf YXRtc3Vici5jCTI4IEFwciAyMDAzIDE1OjUyOjQ4IC0wMDAwDQpAQCAtNDUs MTEgKzQ1LDE0IEBADQogDQogI2luY2x1ZGUgPHN5cy9wYXJhbS5oPg0KICNp bmNsdWRlIDxzeXMvc3lzdG0uaD4NCisjaW5jbHVkZSA8c3lzL2tlcm5lbC5o Pg0KKyNpbmNsdWRlIDxzeXMvbW9kdWxlLmg+DQogI2luY2x1ZGUgPHN5cy9t YWMuaD4NCiAjaW5jbHVkZSA8c3lzL21idWYuaD4NCiAjaW5jbHVkZSA8c3lz L3NvY2tldC5oPg0KICNpbmNsdWRlIDxzeXMvc29ja2lvLmg+DQogI2luY2x1 ZGUgPHN5cy9lcnJuby5oPg0KKyNpbmNsdWRlIDxzeXMvc3lzY3RsLmg+DQog DQogI2luY2x1ZGUgPG5ldC9pZi5oPg0KICNpbmNsdWRlIDxuZXQvbmV0aXNy Lmg+DQpAQCAtNjgsNiArNzEsOCBAQA0KICNpbmNsdWRlIDxuZXRuYXRtL25h dG0uaD4NCiAjZW5kaWYNCiANCitTWVNDVExfTk9ERShfaHcsIE9JRF9BVVRP LCBhdG0sIENUTEZMQUdfUlcsIDAsICJBVE0gaGFyZHdhcmUiKTsNCisNCiAj aWZuZGVmIEVUSEVSVFlQRV9JUFY2DQogI2RlZmluZSBFVEhFUlRZUEVfSVBW NgkweDg2ZGQNCiAjZW5kaWYNCkBAIC0yODMsNyArMjg4LDcgQEANCiB9DQog DQogLyoNCi0gKiBQZXJmb3JtIGNvbW1vbiBkdXRpZXMgd2hpbGUgYXR0YWNo aW5nIHRvIGludGVyZmFjZSBsaXN0DQorICogUGVyZm9ybSBjb21tb24gZHV0 aWVzIHdoaWxlIGF0dGFjaGluZyB0byBpbnRlcmZhY2UgbGlzdC4NCiAgKi8N CiB2b2lkDQogYXRtX2lmYXR0YWNoKGlmcCkNCkBAIC0yOTUsNiArMzAwLDcg QEANCiAJaWZwLT5pZl90eXBlID0gSUZUX0FUTTsNCiAJaWZwLT5pZl9hZGRy bGVuID0gMDsNCiAJaWZwLT5pZl9oZHJsZW4gPSAwOw0KKwlpZl9hdHRhY2go aWZwKTsNCiAJaWZwLT5pZl9tdHUgPSBBVE1NVFU7DQogCWlmcC0+aWZfb3V0 cHV0ID0gYXRtX291dHB1dDsNCiAjaWYgMA0KQEAgLTMyMSwzICszMjcsMjEg QEANCiAJCX0NCiANCiB9DQorDQorLyoNCisgKiBDb21tb24gc3R1ZmYgZm9y IGRldGFjaGluZyBhbiBBVE0gaW50ZXJmYWNlDQorICovDQordm9pZA0KK2F0 bV9pZmRldGFjaChzdHJ1Y3QgaWZuZXQgKmlmcCkNCit7DQorCWlmX2RldGFj aChpZnApOw0KK30NCisNCitzdGF0aWMgbW9kdWxlZGF0YV90IGF0bV9tb2Qg PSB7DQorICAgICAgICAiYXRtIiwNCisgICAgICAgIE5VTEwsDQorICAgICAg ICAwDQorfTsNCisgICAgICAgICAgICAgICAgDQorREVDTEFSRV9NT0RVTEUo YXRtLCBhdG1fbW9kLCBTSV9TVUJfUFNFVURPLCBTSV9PUkRFUl9BTlkpOw0K K01PRFVMRV9WRVJTSU9OKGF0bSwgMSk7DQpJbmRleDogc3lzL3BjaS9pZl9l bl9wY2kuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9l eHBvcnQvY3ZzL2ZyZWVic2Qvc3JjL3N5cy9wY2kvaWZfZW5fcGNpLmMsdg0K cmV0cmlldmluZyByZXZpc2lvbiAxLjIxDQpkaWZmIC11IC1yMS4yMSBpZl9l bl9wY2kuYw0KLS0tIHN5cy9wY2kvaWZfZW5fcGNpLmMJMjUgQXByIDIwMDMg MTY6MTQ6MDIgLTAwMDAJMS4yMQ0KKysrIHN5cy9wY2kvaWZfZW5fcGNpLmMJ MjggQXByIDIwMDMgMTU6NTI6NTAgLTAwMDANCkBAIC02Niw2ICs2Niw5IEBA DQogI2luY2x1ZGUgPGRldi9lbi9taWR3YXlyZWcuaD4NCiAjaW5jbHVkZSA8 ZGV2L2VuL21pZHdheXZhci5oPg0KIA0KK01PRFVMRV9ERVBFTkQoZW4sIHBj aSwgMSwgMSwgMSk7DQorTU9EVUxFX0RFUEVORChlbiwgYXRtLCAxLCAxLCAx KTsNCisNCiAvKg0KICAqIGxvY2FsIHN0cnVjdHVyZXMNCiAgKi8NCkBAIC0y NjIsNyArMjY1LDcgQEANCiAJICAgIGVuX2ludHIsIHNjLCAmc2NwLT5paCk7 DQogCWlmIChlcnJvcikgew0KIAkJZW5fcmVzZXQoc2MpOw0KLQkJaWZfZGV0 YWNoKCZzYy0+ZW5pZik7DQorCQlhdG1faWZkZXRhY2goJnNjLT5lbmlmKTsN CiAJCWRldmljZV9wcmludGYoZGV2LCAiY291bGQgbm90IHNldHVwIGlycVxu Iik7DQogCQlidXNfcmVsZWFzZV9yZXNvdXJjZShkZXYsIFNZU19SRVNfSVJR LCAwLCBzY3AtPmlycSk7DQogCQlidXNfcmVsZWFzZV9yZXNvdXJjZShkZXYs IFNZU19SRVNfTUVNT1JZLCBQQ0lfQ0JNQSwgc2NwLT5yZXMpOw0KQEAgLTI5 Nyw3ICszMDAsNyBAQA0KIAkgKiBDbG9zZSBkb3duIHJvdXRlcyBldGMuDQog CSAqLw0KIAllbl9yZXNldChzYyk7DQotCWlmX2RldGFjaCgmc2MtPmVuaWYp Ow0KKwlhdG1faWZkZXRhY2goJnNjLT5lbmlmKTsNCiANCiAJLyoNCiAJICog RGVhbGxvY2F0ZSByZXNvdXJjZXMuDQo= --0-227327898-1051546066=:931--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030428142022.E931>