Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Dec 2007 21:48:57 +0100 (CET)
From:      Dan Lukes <dan@obluda.cz>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   i386/119175: Typo in bus_dmamem_alloc()
Message-ID:  <200712302048.lBUKmvPu044263@kulesh.obluda.cz>
Resent-Message-ID: <200712302050.lBUKo1Ng094834@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         119175
>Category:       i386
>Synopsis:       Typo in bus_dmamem_alloc()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-i386
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 30 20:50:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Dan Lukes
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
Obludarium
>Environment:
src/sys/i386/i386/busdma_machdep.c,v 1.74.2.5 2007/05/02 18:48:1
but it apply to HEAD's version as well

>Description:

	KTR record ENOMEM error message even if bus_dmamem_alloc() succesfull

>How-To-Repeat:
>Fix:


--- sys/i386/i386/busdma_machdep.c.ORIG	2007-12-30 21:35:48.000000000 +0100
+++ sys/i386/i386/busdma_machdep.c	2007-12-30 21:37:40.000000000 +0100
@@ -529,8 +529,8 @@
 	if (flags & BUS_DMA_NOCACHE)
 		pmap_change_attr((vm_offset_t)*vaddr, dmat->maxsize,
 		    PAT_UNCACHEABLE);
-	CTR4(KTR_BUSDMA, "%s: tag %p tag flags 0x%x error %d",
-	    __func__, dmat, dmat->flags, ENOMEM);
+	CTR3(KTR_BUSDMA, "%s: tag %p tag flags 0x%x",
+	    __func__, dmat, dmat->flags);
 	return (0);
 }
 
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712302048.lBUKmvPu044263>