Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Sep 2008 17:43:09 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To:        Julian Elischer <julian@elischer.org>
Cc:        Marko Zec <zec@FreeBSD.org>, FreeBSD virtualization mailing list <freebsd-virtualization@freebsd.org>
Subject:   Re: Vnet iteration
Message-ID:  <20080916174040.Y65801@maildrop.int.zabbadoz.net>
In-Reply-To: <48C780E4.2050207@elischer.org>
References:  <200809081655.m88GtxbV000906@repoman.freebsd.org> <48C780E4.2050207@elischer.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Marko Zec wrote:

Hi,

>> http://perforce.freebsd.org/chv.cgi?CH=149433
>> 
>> Change 149433 by zec@zec_tpx32 on 2008/09/08 16:55:34
>>
>> 	First-cut replacement of VNET_ITERLOOP_BEGIN() /
>> 	VNET_ITERLOOP_END() kludges with VNET_FOREACH() constructs
>> 	discussed at freebsd-virtualization@
>> 		Needs a bit more testing before merging over to
>> 	vimage-commit2 branch.
>> 
>> Differences ...
>
> [...]
>
>> +	VNET_FOREACH(vnet_iter) {
>> +		CURVNET_SET(vnet_iter);	/* XXX CURVNET_SET_QUIET() ? */
>> +		INIT_VNET_NET(vnet_iter);
>> +		TAILQ_FOREACH(ifp, &V_ifnet, if_link)
>> +			(void)ifaddr_event_handler(NULL, ifp);
>> +		CURVNET_RESTORE();
>>  	}
>
> this looks great..
>
> I'd like to see as much of this as possible in commit2
> and then I'd like to see it committed as soon as brokk, bz and others have 
> kicked the t[yi]res a bit.
> :-)


So can anyone bring it over to commit2? Marko, are you around?

I had been generating a diff last weekend again to push this and found
that the diff size changed from ~200k to ~800k so I suspect there was
a mis-integration or someone forgot to set the label?



/bz

-- 
Bjoern A. Zeeb              Stop bit received. Insert coin for new game.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080916174040.Y65801>