Date: Sun, 06 Jul 2008 10:15:12 +0900 (JST) From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org> To: marcel@freebsd.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 144729 for review Message-ID: <20080706.101512.193761302.nyan@jp.FreeBSD.org> In-Reply-To: <200807051805.m65I5T4Y056554@repoman.freebsd.org> References: <200807051805.m65I5T4Y056554@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <200807051805.m65I5T4Y056554@repoman.freebsd.org> Marcel Moolenaar <marcel@freebsd.org> writes: > @@ -67,9 +65,7 @@ > struct uart_class *class; > unsigned int i, j, ivar; > > - class = &uart_ns8250_class; /* currently ns8250 only */ > - if (class == NULL) > - return (ENXIO); > + class = &uart_i8251_class; > > /* Check the environment. */ > if (uart_getenv(devtype, di, class) == 0) Please revert this change. We want to use ns8250 class as default. And the above comment in the diff was wrong... The uart_i8251_class should be added to the uart_classes in uart_subr.c. --- TAKAHASHI Yoshihiro <nyan@jp.FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080706.101512.193761302.nyan>