Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Apr 2013 02:38:14 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r316696 - in head: . Mk
Message-ID:  <20130428023813.GA26006@FreeBSD.org>
In-Reply-To: <201304272215.r3RMFR3w090280@svn.freebsd.org>
References:  <201304272215.r3RMFR3w090280@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 27, 2013 at 10:15:27PM +0000, Baptiste Daroussin wrote:
> New Revision: 316696
> URL: http://svnweb.freebsd.org/changeset/ports/316696
> 
> Log:
>   Remove any reference to USE_ICONV now that it has been totally replace
>   by USES= iconv
>   
>   Submitted by:	mva
> 
> Modified: head/KNOBS
> ==============================================================================
> --- head/KNOBS	Sat Apr 27 22:09:15 2013	(r316695)
> +++ head/KNOBS	Sat Apr 27 22:15:26 2013	(r316696)
> @@ -96,7 +96,6 @@ GUI			Enable Graphical User Interface
>  H323			Adds support for the H323 protocol
>  HAL			Adds support for HAL
>  HEIMDAL_KRB5		Adds Heimdal kerberos support
> -ICONV			Adds iconv support

Leaving aside the question of how useful is KNOBS file these days (after we
have largely overlapping bsd.options.desc.mk), removing ICONV line from it
had nothing to do with USE_ICONV and should not have been committed.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130428023813.GA26006>