Date: Sun, 22 Jul 2018 20:08:53 +0200 From: Ali Abdallah <aliovx@gmail.com> To: freebsd-multimedia@freebsd.org Subject: mixer_info modify_counter Message-ID: <CAO3OKx8T--EuE3x9K-P4-v70hcnjfmeK%2B7_VTME5ZiVNYGixRw@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Hello, Any reason why the modify_counter bit of mixer_info is not incremented when the mixer gets changed? >From sys/dev/sound/pcm/mixer.c:70 /** * Counter is incremented when applications change any of this * mixer's controls. A change in value indicates that persistent * mixer applications should update their displays. */ But reading the code, it is clear that this is not the case, and the counter remains 0. It is enough to call m->modify_counter++ in mixer_set on line 327 for example to make persistent mixer applications work correctly. Currently they have to poll for all mixer controls, even if no changes were made to the mixer. Best, Ali
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAO3OKx8T--EuE3x9K-P4-v70hcnjfmeK%2B7_VTME5ZiVNYGixRw>