Date: 15 Sep 2002 01:47:10 -0700 From: Eric Anholt <anholt@FreeBSD.org> To: Larry Rosenman <ler@lerctr.org> Cc: John Baldwin <jhb@FreeBSD.org>, Tim Zingelman <zingelman@fnal.gov>, stable@FreeBSD.org, re@FreeBSD.org, David Dawes <dawes@XFree86.Org> Subject: RE: missing break in recent patch to agp_i810.c Message-ID: <1032079636.882.588.camel@anholt.dyndns.org> In-Reply-To: <1032060680.1397.0.camel@lerlaptop.lerctr.org> References: <XFMail.20020914231802.jhb@FreeBSD.org> <1032060680.1397.0.camel@lerlaptop.lerctr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2002-09-14 at 20:31, Larry Rosenman wrote: > On Sat, 2002-09-14 at 22:18, John Baldwin wrote: > > > > On 15-Sep-2002 Tim Zingelman wrote: > > > My I810 system broke and gave this message... > > > > > > agp0: unknown memory configuration, disabling > > > device_probe_and_attach: agp0 attach returned 22 > > > > > > with the 1.1.2.4 revision of agp_i810.c. A little investigation shows > > > there is clearly a missing 'break;' in a switch statement. The following > > > patch fixes it. > > > > > > --- agp_i810.c.RELENG_4 Sat Sep 14 19:27:10 2002 > > > +++ agp_i810.c Sat Sep 14 20:56:16 2002 > > > @@ -219,6 +219,7 @@ > > > case 0x71258086: > > > case 0x11328086: > > > sc->chiptype = CHIP_I810; > > > + break; > > > case 0x35778086: > > > case 0x25628086: > > > sc->chiptype = CHIP_I830; > > > > > > Release engineering please consider commit approval for this fix. > > > > Certainly! Approved conditional on Eric's consent. Thanks for testing > > this and tracking this down. > It also does NOT break the I830 support. Please commit.... Okay, it's committed to -current and -stable. Hope it works now. Thanks! -- Eric Anholt <eta@lclark.edu> http://people.freebsd.org/~anholt/dri/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1032079636.882.588.camel>