Date: Mon, 25 Apr 2005 03:01:14 -0500 From: Jon Noack <noackjr@alumni.rice.edu> To: Nate Lawson <nate@root.org> Cc: freebsd-acpi@freebsd.org Subject: Re: [cpufreq] speedstep support via GSI driver Message-ID: <426CA3CA.2050301@alumni.rice.edu> In-Reply-To: <426539B0.4040100@root.org> References: <20050413123022.GR2298@poupinou.org> <426539B0.4040100@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------000408020104060900020604 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 04/19/05 12:02, Nate Lawson wrote: > Bruno Ducrot wrote: >> The smist driver (speedstep support for older kind of Intel's speedstep) >> is (maybe?) ready for inclusion. I CC to -acpi in order to get more >> feedback about this. >> It was tested on current with success by Jon (but should work with >> stable as well). >> >> The driver is available at >> http://www.poupinou.org/cpufreq/bsd/smist.tar.gz >> or >> http://www.poupinou.org/cpufreq/bsd/smist/smist.c > > Ok, it has been imported with minor changes. Let me know if you have > any problems. Sorry for the delay in getting back to you on this, but my laptop and recent -CURRENT weren't playing well together. The driver does not attach during the boot process and I see no messages with a verbose boot. I'm not sure if this ever worked; I may have always loaded the module after booting. In any case, I cleaned up the identify method and added some debug printouts (see attached diff). With those changes I see the following with a verbose boot: smist: could not find supported isa bridge! If I load the module after booting I see the following line (in addition to others): smist: found supported isa bridge Intel PIIX4 ISA bridge I can only assume that during the boot the call to pci_find_device is failing. Any ideas? Again, everything works fine if I load the module after booting. Regards, Jon --------------000408020104060900020604 Content-Type: text/x-patch; name="smist.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="smist.diff" --- /sys/i386/cpufreq/smist.c Tue Apr 19 11:38:24 2005 +++ smist.c Mon Apr 25 02:38:01 2005 @@ -228,7 +228,8 @@ struct piix4_pci_device *id; device_t piix4 = NULL; - if (resource_disabled("ichst", 0)) + /* Make sure we're not being doubly invoked. */ + if (device_find_child(parent, "smist", -1) != NULL) return; /* Check for a supported processor */ @@ -239,6 +240,8 @@ case 0x6a0: /* Pentium III [Tualatin] */ break; default: + if (bootverbose) + printf("smist: could not find supported processor!\n"); return; } @@ -247,14 +250,15 @@ if ((piix4 = pci_find_device(id->vendor, id->device)) != NULL) break; } - if (!piix4) + if (!piix4) { + if (bootverbose) + printf("smist: could not find supported isa bridge!\n"); return; + } if (bootverbose) printf("smist: found supported isa bridge %s\n", id->desc); - if (device_find_child(parent, "smist", -1) != NULL) - return; if (BUS_ADD_CHILD(parent, 0, "smist", -1) == NULL) device_printf(parent, "smist: add child failed\n"); } --------------000408020104060900020604--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?426CA3CA.2050301>