Date: Sun, 22 Jun 2008 15:24:08 +0000 From: Jens Rehsack <rehsack@web.de> To: bug-followup@FreeBSD.org, delphij@freebsd.org, FreeBSD GNOME Users <gnome@freebsd.org> Subject: Re: ports/124115: net/openldap24-server: Auto-Detect OpenLDAP version and modify knobs according to common names Message-ID: <485E6E98.9000106@web.de>
next in thread | raw e-mail | index | archive | help
Hi,
I tried a little around with the submitted patch and detected 2 issues:
1) I had a typo in line 37 of bsd.ldap.mk
-DEFAULT_OPENLDPAP_VER?= 23
+DEFAULT_OPENLDAP_VER?= 23
It's quite easy to fix it ;)
2) A port (security/seahorse) checks in line 72 for ${WANT_OPENLDAP_VER},
which is deprecated. By the way - it doesn't want to check for
WANT_OPENLDAP_VER, it wants to check for ${OPENLDAP_VER}.
Doing this would require to split the "code" in bsd.ldap.mk into a
pre- and post-part, not handle everything in the post-part.
What do you think?
/Jens
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?485E6E98.9000106>