Date: Sun, 02 Nov 2008 09:46:02 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: standards@freebsd.org Subject: Fw: [Qemu-devel] [5530] Fix undefined pthread_sigmask warning on OpenBSD Message-ID: <20081102.094602.-1751001037.imp@bsdimp.com>
next in thread | raw e-mail | index | archive | help
----Next_Part(Sun_Nov__2_09_46_02_2008_819)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Looks like Blue Swirl is right... Would anybody object to picking up the changes from NetBSD? Warner ----Next_Part(Sun_Nov__2_09_46_02_2008_819)-- Content-Type: Message/Rfc822 Content-Transfer-Encoding: 7bit Content-Disposition: inline Delivery-Date: Sun, 26 Oct 2008 04:07:20 -0600 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on harmony.bsdimp.com X-Spam-Level: * X-Spam-Status: No, score=1.3 required=3.5 tests=EMPTY_MESSAGE, MISSING_SUBJECT, NO_RECEIVED autolearn=no version=3.2.5 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m9QA76ja051524 for <imp@bsdimp.com>; Sun, 26 Oct 2008 04:07:06 -0600 (MDT) (envelope-from qemu-devel-bounces+imp=bsdimp.com@nongnu.org) Received: from localhost ([127.0.0.1]:35596 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ku2K9-0003CP-C4 for imp@bsdimp.com; Sun, 26 Oct 2008 05:54:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ku2IV-0003Ab-4x for qemu-devel@nongnu.org; Sun, 26 Oct 2008 05:52:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ku2IQ-00037D-UW for qemu-devel@nongnu.org; Sun, 26 Oct 2008 05:52:34 -0400 Received: from [199.232.76.173] (port=45447 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ku2IQ-000376-NS for qemu-devel@nongnu.org; Sun, 26 Oct 2008 05:52:30 -0400 Received: from wf-out-1314.google.com ([209.85.200.173]:53881) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from <blauwirbel@gmail.com>) id 1Ku2IQ-0005yO-7R for qemu-devel@nongnu.org; Sun, 26 Oct 2008 05:52:30 -0400 Received: by wf-out-1314.google.com with SMTP id 27so1566675wfd.4 for <qemu-devel@nongnu.org>; Sun, 26 Oct 2008 02:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=jTSuEaiU/4crWvd8v0kwDAqaDQpEu6rTHSdzn5oIqrw=; b=IyfF72IcNW6AqpqbxMlsNIEa9tpsChFsKPxa2HzAhiHzScdbtmwbgbj/ORVJolKtIu KTvWxzBzBoq0KzxBdk0rHnM4GxdfFToX82sGYzc3+MMyXIx+7PNNTu24JGSmv0xspux9 mzBCKifv3LyDWMHEJt/ctQFTN1V20rqLU8puk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=VvV/5BflfTBDPb4CwciFpKTrJq3IhMOtBvqWnhmIX4+Fw+oac70D79cioWEwhYcOgW 0nquHdU13kZ5n4tePIHD3m8f3aFph/n9+SrieYncldJPlBjBN0f1F4VaM4mLjp2MeaOR OS6p++h/E5/QgmMB+Ec8QeKzFwbO9PjpJy1jU= Received: by 10.142.173.14 with SMTP id v14mr1988624wfe.231.1225014748776; Sun, 26 Oct 2008 02:52:28 -0700 (PDT) Received: by 10.143.15.12 with HTTP; Sun, 26 Oct 2008 02:52:28 -0700 (PDT) Message-ID: <f43fc5580810260252y6f418b59pb992d419dca1472a@mail.gmail.com> Date: Sun, 26 Oct 2008 11:52:28 +0200 From: "Blue Swirl" <blauwirbel@gmail.com> To: "Juergen Lock" <nox@jelal.kn-bremen.de> Subject: Re: [Qemu-devel] [5530] Fix undefined pthread_sigmask warning on OpenBSD In-Reply-To: <200810252114.m9PLEqUW077079@saturn.kn-bremen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <E1KthAo-0006G1-Pq@cvs.savannah.gnu.org> <200810252114.m9PLEqUW077079@saturn.kn-bremen.de> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: qemu-devel@nongnu.org X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>; List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Sender: qemu-devel-bounces+imp=bsdimp.com@nongnu.org Errors-To: qemu-devel-bounces+imp=bsdimp.com@nongnu.org On 10/25/08, Juergen Lock <nox@jelal.kn-bremen.de> wrote: > Hi! > > > In article <E1KthAo-0006G1-Pq@cvs.savannah.gnu.org> you write: > >Revision: 5530 > > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5530 > >Author: blueswir1 > >Date: 2008-10-25 11:19:14 +0000 (Sat, 25 Oct 2008) > > > >Log Message: > >----------- > >Fix undefined pthread_sigmask warning on OpenBSD > > > >Modified Paths: > >-------------- > > trunk/audio/sdlaudio.c > > > >Modified: trunk/audio/sdlaudio.c > >=================================================================== > >--- trunk/audio/sdlaudio.c 2008-10-25 11:18:12 UTC (rev 5529) > >+++ trunk/audio/sdlaudio.c 2008-10-25 11:19:14 UTC (rev 5530) > >@@ -29,6 +29,8 @@ > > #ifndef _WIN32 > > #ifdef __sun__ > > #define _POSIX_PTHREAD_SEMANTICS 1 > >+#elif defined(__OpenBSD__) > >+#include <pthread.h> > > #endif > > #include <signal.h> > > #endif > > > > I forgot to mention that I also patched this for FreeBSD, so the above > > >+#elif defined(__OpenBSD__) > > can be changed to > > >+#elif defined(__OpenBSD__) || defined(__FreeBSD__) > > Or do I need to send a proper patch? :) No, I'll just copy and paste. It looks like NetBSD uses signal.h like everyone should. http://www.opengroup.org/onlinepubs/009695399/functions/pthread_sigmask.html http://cvsweb.netbsd.org/bsdweb.cgi/src/include/signal.h?rev=1.50&content-type=text/x-cvsweb-markup&only_with_tag=MAIN ----Next_Part(Sun_Nov__2_09_46_02_2008_819)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081102.094602.-1751001037.imp>