Date: Sun, 7 Dec 2008 00:26:33 GMT From: Marko Zec <zec@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 154226 for review Message-ID: <200812070026.mB70QXpt036322@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=154226 Change 154226 by zec@zec_tpx32 on 2008/12/07 00:26:21 Improve style and remove an XXX comment which no longer holds. Affected files ... .. //depot/projects/vimage-commit2/src/sys/kern/kern_linker.c#6 edit .. //depot/projects/vimage-commit2/src/sys/kern/kern_vimage.c#4 edit .. //depot/projects/vimage-commit2/src/sys/netinet/tcp_subr.c#36 edit Differences ... ==== //depot/projects/vimage-commit2/src/sys/kern/kern_linker.c#6 (text+ko) ==== @@ -1311,10 +1311,9 @@ CURVNET_SET(TD_TO_VNET(td)); error = vi_symlookup(&lookup, symstr); CURVNET_RESTORE(); - if (error == 0) { + if (error == 0) error = copyout(&lookup, uap->data, sizeof(lookup)); - } } #else if (lf == NULL) ==== //depot/projects/vimage-commit2/src/sys/kern/kern_vimage.c#4 (text+ko) ==== @@ -82,12 +82,12 @@ if (strcmp(symstr, mapentry->name) == 0) { lookup->symvalue = (u_long) mapentry->base; lookup->symsize = mapentry->size; - return 0; + return (0); } } } - return ENOENT; + return (ENOENT); } static void ==== //depot/projects/vimage-commit2/src/sys/netinet/tcp_subr.c#36 (text+ko) ==== @@ -1483,7 +1483,6 @@ #define ISN_RANDOM_INCREMENT (4096 - 1) #ifdef VIMAGE_GLOBALS -/* XXX WARNING WARNING clash with contrib/pf/net/pf_subr.c - REVISIT !!! */ static u_char isn_secret[32]; static int isn_last_reseed; static u_int32_t isn_offset, isn_offset_old;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812070026.mB70QXpt036322>