Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Oct 2017 22:18:40 -0700
From:      Ngie Cooper <yaneurabeya@gmail.com>
To:        Sean Bruno <sbruno@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r324406 - head/sys/modules/em
Message-ID:  <95D45458-24C3-473C-80AF-A2C622747886@gmail.com>
In-Reply-To: <201710072333.v97NXE6E044433@repo.freebsd.org>
References:  <201710072333.v97NXE6E044433@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

> On Oct 7, 2017, at 16:33, Sean Bruno <sbruno@FreeBSD.org> wrote:
>=20
> Author: sbruno
> Date: Sat Oct  7 23:33:14 2017
> New Revision: 324406
> URL: https://svnweb.freebsd.org/changeset/base/324406
>=20
> Log:
>  Fix symlink if_igb.ko in -current such that its relative and doesn't
>  end up with non-standard DESTDIR information in its symlink.  This
>  can happen very trivially if the release scripts are used.
>=20
>  Sponsored by:    Limelight Networks
>=20
> Modified:
>  head/sys/modules/em/Makefile
>=20
> Modified: head/sys/modules/em/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> --- head/sys/modules/em/Makefile    Sat Oct  7 23:30:57 2017    (r324405)
> +++ head/sys/modules/em/Makefile    Sat Oct  7 23:33:14 2017    (r324406)
> @@ -23,6 +23,6 @@ CFLAGS +=3D -I${SRCTOP}/sys/dev/e1000
> #CFLAGS  +=3D -DDEVICE_POLLING
>=20
> afterinstall:
> -    ln -sf ${DESTDIR}${KMODDIR}/${KMOD}.ko ${DESTDIR}${KMODDIR}/if_igb.ko=

> +    cd ${DESTDIR}${KMODDIR} && ln -sf if_em.ko if_igb.ko

While this is definitely better, the same thing could be achieved via:

ln -sf if_em.ko ${DESTDIR}/.../if_igb.ko=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95D45458-24C3-473C-80AF-A2C622747886>