Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Oct 2018 07:04:45 +0000 (UTC)
From:      "Andrey V. Elsukov" <ae@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r339580 - stable/11/sys/netpfil/ipfw
Message-ID:  <201810220704.w9M74jKS082625@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ae
Date: Mon Oct 22 07:04:44 2018
New Revision: 339580
URL: https://svnweb.freebsd.org/changeset/base/339580

Log:
  MFC r339357:
    Add extra parentheses to fix "versrcreach" opcode, (oif != NULL) should
    not be used as condition for ternary operator.
  
    Submitted by:	Tatsuki Makino <tatsuki_makino at hotmail dot com>

Modified:
  stable/11/sys/netpfil/ipfw/ip_fw2.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/netpfil/ipfw/ip_fw2.c
==============================================================================
--- stable/11/sys/netpfil/ipfw/ip_fw2.c	Mon Oct 22 06:44:20 2018	(r339579)
+++ stable/11/sys/netpfil/ipfw/ip_fw2.c	Mon Oct 22 07:04:44 2018	(r339580)
@@ -2353,13 +2353,13 @@ do {								\
 
 			case O_VERSRCREACH:
 				/* Outgoing packets automatically pass/match */
-				match = (hlen > 0 && ((oif != NULL) ||
+				match = (hlen > 0 && ((oif != NULL) || (
 #ifdef INET6
 				    is_ipv6 ?
 				        verify_path6(&(args->f_id.src_ip6),
 				            NULL, args->f_id.fib) :
 #endif
-				    verify_path(src_ip, NULL, args->f_id.fib)));
+				    verify_path(src_ip, NULL, args->f_id.fib))));
 				break;
 
 			case O_ANTISPOOF:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201810220704.w9M74jKS082625>