Date: Tue, 3 Jun 2008 10:04:43 -0400 From: John Baldwin <jhb@freebsd.org> To: Coleman Kane <cokane@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/if_ndis if_ndis.c if_ndisvar.h Message-ID: <200806031004.43883.jhb@freebsd.org> In-Reply-To: <200806030055.m530tqVF044140@repoman.freebsd.org> References: <200806030055.m530tqVF044140@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 02 June 2008 08:55:48 pm Coleman Kane wrote: > cokane 2008-06-03 00:55:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/if_ndis if_ndis.c if_ndisvar.h > Log: > SVN rev 179498 on 2008-06-03 00:55:48Z by cokane > > Update if_ndis to remove the legacy if_watchdog interface and > bring it more up to date. The watchdog timer, and its > associated code, is all collapsed into the ndis_tick function > that was implemented for the NDIS-subsystem watchdog. This > implementation is similar to what numerous other drivers use > to implement the watchdog. > > Reviewed by: thompsa, jhb > MFC after: 2 weeks You should make the callout routine use callout_init_mtx() instead as it is less race-prone. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806031004.43883.jhb>