Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Feb 2013 12:52:26 -0500
From:      Ed Maste <emaste@freebsd.org>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r244157 - head/sys/netinet
Message-ID:  <CAPyFy2Ashh8Tm%2BzzVzOi4Z3XvkNBpBCKjgUaHRYHn80Zqwyyeg@mail.gmail.com>
In-Reply-To: <201212121741.qBCHfM6Q008489@svn.freebsd.org>
References:  <201212121741.qBCHfM6Q008489@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12 December 2012 12:41, Gleb Smirnoff <glebius@freebsd.org> wrote:
> Author: glebius
> Date: Wed Dec 12 17:41:21 2012
> New Revision: 244157
> URL: http://svnweb.freebsd.org/changeset/base/244157
>
> Log:
>     Fix a crash in tcp_input(), that happens when mbuf has a fwd_tag on it,
>   but later after processing and freeing the tag, we need to jump back again
>   to the findpcb label. Since the fwd_tag pointer wasn't NULL we tried to
>   process and free the tag for second time.

This will fix the crash, but I worry that packets matching the
TIMEWAIT cases that previously caused the crash will now fail to be
forwarded instead.

I'm looking at separating the detach and free of the fwd_tag to address this.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2Ashh8Tm%2BzzVzOi4Z3XvkNBpBCKjgUaHRYHn80Zqwyyeg>