Date: Wed, 03 Oct 2018 04:31:58 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 231770] databases/sqlite3: Add ICU flavor Message-ID: <bug-231770-7788-QogGQJ5RJF@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-231770-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-231770-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231770 Matt <fsbruva@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197558|0 |1 is obsolete| | --- Comment #3 from Matt <fsbruva@yahoo.com> --- Created attachment 197729 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D197729&action= =3Dedit Add flavors - default, icu and mini I tested your patch tonight - and it behaved as I expected: users can de-se= lect the "ICU" option during `make config`. This is not appropriate. I looked more closely at the Makefile for editors/emacs, and emulated the u= se of OPTIONS_EXCLUDE to force the relevant build behavior for the icu and mini flavors. While attempting that, I completely re-organized the Makefile to conform to the guidance of [1], especially [2]. Following the major edit, I audited the two versions to ensure I hadn't missed anything. [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html [2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-options= .html --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-231770-7788-QogGQJ5RJF>