Date: Thu, 27 Sep 2012 12:48:36 -0600 From: "Kenneth D. Merry" <ken@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, jdp@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, phk@FreeBSD.org Subject: Re: svn commit: r240822 - head/sys/geom Message-ID: <20120927184836.GA87386@nargothrond.kdm.org> In-Reply-To: <20120927181624.GX1402@garage.freebsd.pl> References: <201209221241.q8MCfnhJ067937@svn.freebsd.org> <20120925233712.GA26920@nargothrond.kdm.org> <20120926072005.GH1391@garage.freebsd.pl> <20120926172917.GA71268@nargothrond.kdm.org> <20120926185339.GA1402@garage.freebsd.pl> <20120926192117.GA89741@nargothrond.kdm.org> <20120926194541.GB1402@garage.freebsd.pl> <20120927181624.GX1402@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 27, 2012 at 20:16:25 +0200, Pawel Jakub Dawidek wrote: > On Wed, Sep 26, 2012 at 09:45:41PM +0200, Pawel Jakub Dawidek wrote: > > On Wed, Sep 26, 2012 at 01:21:17PM -0600, Kenneth D. Merry wrote: > > > Ahh. How about using LIST_FOREACH_SAFE? Would that address the problem at > > > hand? Are there any other races in there? > > > > It depends. If one geom can hold more than one provider then it might be > > racy, but from what I see there is always only one provider - there has > > to be only one, because disk_destroy() destroys it and struct disk > > represents always only one disk. If that's true then I see not reason to > > have a loop in there. I'd change it to: > > > > void > > disk_gone(struct disk *dp) > > { > > struct g_geom *gp; > > struct g_provider *pp; > > > > gp = dp->d_geom; > > if (gp != NULL) { > > pp = LIST_FIRST(&gp->provider); > > if (pp != NULL) > > g_wither_provider(pp, ENXIO); > > } > > } > > Final patch for review: > > http://people.freebsd.org/~pjd/patches/geom_disk.c.3.patch Looks good, thanks! Ken -- Kenneth Merry ken@FreeBSD.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120927184836.GA87386>