Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 02 Nov 2013 12:18:24 +0200
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Mark Johnston <markj@FreeBSD.org>
Cc:        dtrace@FreeBSD.org
Subject:   Re: "unstable" sdt probes
Message-ID:  <5274D170.6050505@FreeBSD.org>
In-Reply-To: <20131102041240.GA23329@raichu>
References:  <5268F461.7080504@FreeBSD.org> <20131024161620.GA1710@charmander> <526A9CB5.2050207@FreeBSD.org> <20131026180643.GA98676@raichu> <527026B3.2070309@FreeBSD.org> <20131031035523.GD9355@raichu> <52720017.3060809@FreeBSD.org> <20131102041240.GA23329@raichu>

next in thread | previous in thread | raw e-mail | index | archive | help
on 02/11/2013 06:12 Mark Johnston said the following:
> Sure, there are multiple probe sites for the sdt:::arc-miss probe, for
> example. For the ip provider, there are multiple probe sites for
> ip:::receive: at least one for IPv4, and at least one for IPv6.

Okay, I think that the following lines in sdt_create_probe should handle this:
        if (dtrace_probe_lookup(prov->id, mod, func, name) != DTRACE_IDNONE)
                return;

It's, of course, a little bit wasteful to have a few duplicate sdt_probe and
sdt_argtype structs, but should not be too terrible.

I wonder if there is some low level trick to collapse this duplicates into a
single object during linking.  Probably not...

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5274D170.6050505>