Date: Thu, 11 Jun 2009 15:39:57 +0200 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Attilio Rao <attilio@freebsd.org> Cc: current@freebsd.org Subject: Re: proposed bio.h change Message-ID: <20090611133957.GA23404@onelab2.iet.unipi.it> In-Reply-To: <3bbf2fe10906110628l24d538ccu6ef9c5af354638ab@mail.gmail.com> References: <20090611130800.GA22241@onelab2.iet.unipi.it> <3bbf2fe10906110628l24d538ccu6ef9c5af354638ab@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 11, 2009 at 03:28:32PM +0200, Attilio Rao wrote: > 2009/6/11 Luigi Rizzo <rizzo@iet.unipi.it>: > > I noticed that sys/sys/bio.h unnecessarily exposes various > > structures to userland. > > If there are no objections I would like to commit the > > following change (moving the bio_cmd values up because > > they are used by ggatectl) > > I think you should export CMD too for this interface. I am not sure what you are referring to with 'CMD'. The only strings matching 'CMD' are the bio_cmd #defines, which as i said are exported, and the uint8_t bio_cmd field in struct bio, which is passed up by the ioctl() as a field of a separate struct, which contains only a subset of struct bio fields. Anything else I don't see ? cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090611133957.GA23404>