Date: Thu, 24 Jun 2004 14:55:24 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Josef El-Rayes <josef@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pcm mixer.c Message-ID: <200406241455.24148.jhb@FreeBSD.org> In-Reply-To: <20040624181801.GD583@jenny.daemon.li> References: <200406241741.i5OHfKjn052472@repoman.freebsd.org> <200406241408.08014.jhb@FreeBSD.org> <20040624181801.GD583@jenny.daemon.li>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 24 June 2004 02:18 pm, Josef El-Rayes wrote: > John Baldwin <jhb@FreeBSD.org> wrote: > > Does this really need to be here considering that with rcNG (on by > > default on current) and /etc/rc.d/mixer this has no effect? > > Eugene Grosbein requested this (kern/63771) implicitely > and Cameron Grant decided that it is good to accomplish > this via kenv variables. > > It literally adds only ~5 lines of code, it does not > decrease stability but adds a feature, I see > lots of kernel modules configurated via hints and > bootloader, why not let pcm be configured via this too. > Why do we have to force users to use mixer script, which > is not documented anywhere too. > > I will, of course, remove it, if it is wished, I just > dont see why anyone would have a problem. It's more that in its current form it doesn't do anything. :) If you had run this code on a current box with rcNG you would have found that out before committing so that a solution could be worked out. As it is now, you could already achieve the desired functionality by simply muting the channel while the box was in multiuser and the channel would stay muted across reboots until you explicitly unmute it. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406241455.24148.jhb>