Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 05 Jan 2004 17:29:54 -0500 (EST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Nate Lawson <nate@root.org>
Cc:        hackers@freebsd.org
Subject:   Re: Power Patches
Message-ID:  <XFMail.20040105172954.jhb@FreeBSD.org>
In-Reply-To: <20040102151458.P10254@root.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 04-Jan-2004 Nate Lawson wrote:
> I get a panic on my T23 due to the ATA driver not being detected so no
> rootvp.  Attached are dmesg both before and after the patch.  The cbb0
> issue is a regression since I have specified it to use an unused IO range
> via this tunable (the same range Windows uses):
> 
>    hw.cbb.start_memory=0xc0203000
> 
> I commented out that tunable while testing the power kernel.
> 
> One thing you should fix is calling the acpi set methods with a NULL
> pointer:
> 
>   pci2: Failed to set ACPI power state D3 on (null): AE_BAD_PARAMETER
> 
> You should probably just skip the call to the acpi set power state if it's
> null.

Well, see, I'm not sure yet what pointer is null.  That is the output
of acpi_name() on a handle.  It would help to know what bus/device/func
that is and if your ASL has a correspondnig device in the tree or not.
It may be that acpi_handle() is returning NULL and in that case I guess
we should just not try to adjust ACPI power resources/_PSx but just
stick to the pci powerstate stuff.  If you could verify what is actually
NULL that could help however.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20040105172954.jhb>