Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Jun 2010 16:16:05 -0500
From:      Nathan Whitehorn <nwhitehorn@freebsd.org>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r209511 - head
Message-ID:  <20100624161605.5b7c4b1a@anacreon.physics.wisc.edu>
In-Reply-To: <20100624.144153.705015198875273131.imp@bsdimp.com>
References:  <201006241753.o5OHrPnU058288@svn.freebsd.org> <20100624151959.6b00bfdd@anacreon.physics.wisc.edu> <20100624.144153.705015198875273131.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 24 Jun 2010 14:41:53 -0600 (MDT)
"M. Warner Losh" <imp@bsdimp.com> wrote:

> In message: <20100624151959.6b00bfdd@anacreon.physics.wisc.edu>
>             Nathan Whitehorn <nwhitehorn@freebsd.org> writes:
> : On Thu, 24 Jun 2010 17:53:25 +0000 (UTC)
> : Warner Losh <imp@FreeBSD.org> wrote:
> : 
> : > Author: imp
> : > Date: Thu Jun 24 17:53:25 2010
> : > New Revision: 209511
> : > URL: http://svn.freebsd.org/changeset/base/209511
> : > 
> : > Log:
> : >   Merge from tbemd:
> : >   
> : >   use MACHINE_CPUARCH instead of MACHINE_CPU since the sources
> for the : >   CSU is based on MACHINE_CPUARCH
> : >   
> : >   Reviewed by:	arch@ (twice)
> : 
> : This is not always true. For example, on powerpc64, the ABI is
> : different enough between powerpc and powerpc64, which share a
> CPUARCH, : that the csu code shares very little. I can work around
> this with : Makefile or preprocessor hacks, of course, but would be
> it be possible : here instead to check for MACHINE_ARCH before
> falling back to : MACHINE_CPUARCH?
> 
> Does this patch do what you are asking?

Are you sure you attached the right patch?
-Nathan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100624161605.5b7c4b1a>