Skip site navigation (1)Skip section navigation (2)
Date:      15 Mar 2003 13:16:54 -0500
From:      Joe Marcus Clarke <marcus@marcuscom.com>
To:        Alexander Leidinger <Alexander@Leidinger.net>
Cc:        DougB@FreeBSD.ORG, ports@FreeBSD.ORG
Subject:   Re: Fail to build XEmacs with GTK
Message-ID:  <1047752213.81982.10.camel@shumai.marcuscom.com>
In-Reply-To: <20030315143137.57769881.Alexander@Leidinger.net>
References:  <OE51K6qSX422M3fJTmh0000e396@hotmail.com> <1047615404.66262.7.camel@shumai.marcuscom.com> <20030314043154.GA94526@rot13.obsecurity.org> <1047616453.66262.10.camel@shumai.marcuscom.com> <20030313230858.H1839@znfgre.tberna.bet> <1047645619.2553.4.camel@shumai.marcuscom.com> <20030314210940.N1839@znfgre.tberna.bet> <1047709502.75367.3.camel@shumai.marcuscom.com> <20030315143137.57769881.Alexander@Leidinger.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--=-WG4BSHfH+zv4K0BG2h20
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 2003-03-15 at 08:31, Alexander Leidinger wrote:
> On 15 Mar 2003 01:25:02 -0500
> Joe Marcus Clarke <marcus@marcuscom.com> wrote:
>=20
> > > > (And, for backwards compatibility's sake, WITH_GTK will still be ar=
ound
> > > > for a while).
> > >=20
> > > IMO, it should stay around in perpetuity.
> >=20
> > For the reasons I listed above, I don't think this is a good idea.  Why
> > is it such a problem to substitute WITH_GTK with USE_GNOME=3Dgtk12?  Af=
ter
> > all, this is documented.

Sorry, I was tired last night.  This should have said:

USE_GTK vs. USE_GNOME=3Dgtk12

>=20
> I think Doug is concerned about how this looks to people which aren't
> that familiar with the ports tree.
>=20
> It's ok for port maintainers/committers, but for an 'ordinary' user it
> may sound as it needs/depends on GNOME. And if such an user doesn't want
> GNOME to get installed, he may decide to not install such a port without
> trying if it actually installs GNOME or not.

The port author is still the one in control, and is free to use WITH_GTK
as a knob if they desire.  However, they have to translate that in their
port to be USE_GNOME=3Dgtk12 instead of USE_GTK.  Therefore, they can
still do something like this:

pre-configure::
	@${ECHO_MSG} ""
	@${ECHO_MSG} "This sport has the following option(s):"
	@${ECHO_MSG} ""
	@${ECHO_MSG} "WITH_GTK=3Dyes	Enable GTK+-1.2 support"
	@${ECHO_MSG} ""

Then they can add something like this:

.if defined(WITH_GTK)
USE_GNOME=3D	gtk12
.endif

However, they are free to also use the built-in WANT_GNOME/HAVE_GNOME
method with handles autodetection as well:

WANT_GNOME=3D	yes
...
.if ${HAVE_GNOME:Mgtk12}!=3D""
USE_GNOME=3D	gtk12
.endif

And even combine them if they like:

WANT_GNOME=3D	yes
...
.if ${HAVE_GNOME:Mgtk12}!=3D"" || defined(WITH_GTK)
USE_GNOME=3D	gtk12
.endif

All of this can be made transparent to the end user.  It's just that in
GNOMENG (soon to be just regular GNOME), the WITH_GTK macro is no longer
magical.  It's no longer reserved.  The porter is still free to use it,
though.  Hope this helps clear things up a bit.

Joe

>=20
> Bye,
> Alexander.
--=20
PGP Key : http://www.marcuscom.com/pgp.asc

--=-WG4BSHfH+zv4K0BG2h20
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQA+c24Vb2iPiv4Uz4cRAqOSAJ4yG4AnYfzaltvtIPG+D1mAc7Yg6wCdErLv
ca286K79GeMniDAziQfMZdQ=
=iq8u
-----END PGP SIGNATURE-----

--=-WG4BSHfH+zv4K0BG2h20--


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1047752213.81982.10.camel>