Date: Thu, 29 Dec 2016 06:38:10 -0800 (PST) From: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> To: Michael Tuexen <tuexen@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r310773 - in stable/11/sys: netinet netinet6 Message-ID: <201612291438.uBTEcARM006548@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201612291132.uBTBWgLM065597@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: tuexen > Date: Thu Dec 29 11:32:42 2016 > New Revision: 310773 > URL: https://svnweb.freebsd.org/changeset/base/310773 > > Log: > MFC r310590: > > Whitespace changes. > > The toolchain for processing the sources has been updated. No functional > change. What tool chain? It is still broken in at least 1 respect: > /* now use the rest of the mbuf chain for the text */ > while (m_tmp != NULL) { > if ((SCTP_BUF_NEXT(m_tmp) == NULL) && trailer) { > - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset, > + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset, ^^^^^^^^^^^^^^ > SCTP_BUF_LEN(m_tmp) - (trailer + m_offset)); > } else { > - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset, > + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset, ^^^^^^^^^^^ > SCTP_BUF_LEN(m_tmp) - m_offset); > } > ... others errors of this type occur in this patch. I think it would of been better to revert the old patch that messed up some comments before creating this change as now there are other changes intermingled making the 2 changes inter-dependent. Even with this small nit, I applaud the number of style(9) corrections! -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201612291438.uBTEcARM006548>