Date: Thu, 17 Jan 2019 17:12:23 -0700 From: Kevin Bowling <kevin.bowling@kev009.com> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343125 - head/sys/dev/ioat Message-ID: <CAK7dMtDYn1YibihevChTP8SBN1wjC3A1VBzXxdfsTPquhDwCyw@mail.gmail.com> In-Reply-To: <201901172321.x0HNL2f4036088@repo.freebsd.org> References: <201901172321.x0HNL2f4036088@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Out of curiosity are you using this driver? Any performance data? On Thu, Jan 17, 2019 at 4:21 PM Conrad Meyer <cem@freebsd.org> wrote: > Author: cem > Date: Thu Jan 17 23:21:02 2019 > New Revision: 343125 > URL: https://svnweb.freebsd.org/changeset/base/343125 > > Log: > ioat(4): Set __result_use_check on ioat_acquire_reserve > > Even M_WAITOK callers must check for failure. For example, if the > device is > quiescing, either due to automatic error-recovery induced reset, or due > to > administrative detach, the routine will return ENXIO and the acquire > reference will not be held. So, there is no mode in which it is safe to > assume the routine succeeds without checking. > > Sponsored by: Dell EMC Isilon > > Modified: > head/sys/dev/ioat/ioat.h > > Modified: head/sys/dev/ioat/ioat.h > > ============================================================================== > --- head/sys/dev/ioat/ioat.h Thu Jan 17 22:00:02 2019 (r343124) > +++ head/sys/dev/ioat/ioat.h Thu Jan 17 23:21:02 2019 (r343125) > @@ -173,7 +173,8 @@ void ioat_release(bus_dmaengine_t dmaengine); > * > * On failure, the caller does not hold the dmaengine. > */ > -int ioat_acquire_reserve(bus_dmaengine_t dmaengine, unsigned n, int > mflags); > +int ioat_acquire_reserve(bus_dmaengine_t dmaengine, unsigned n, int > mflags) > + __result_use_check; > > /* > * Issue a blockfill operation. The 64-bit pattern 'fillpattern' is > written to > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAK7dMtDYn1YibihevChTP8SBN1wjC3A1VBzXxdfsTPquhDwCyw>