Date: Sat, 05 May 2001 06:08:35 +0900 From: "Akinori MUSHA" <knu@iDaemons.org> To: Will Andrews <will@physics.purdue.edu>, portmgr@FreeBSD.org Cc: Eric Melville <eric@FreeBSD.org>, FreeBSD Ports <ports@FreeBSD.org> Subject: Re: port policies Message-ID: <863dakddpo.wl@archon.local.idaemons.org> In-Reply-To: <20010504143140.J3246@casimir.physics.purdue.edu> References: <200104300810.f3U8AGY60114@freefall.freebsd.org> <86elua4wf1.wl@archon.local.idaemons.org> <20010430023347.A70094@xor.obsecurity.org> <20010504123304.B66630@FreeBSD.org> <20010504143140.J3246@casimir.physics.purdue.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
At Fri, 4 May 2001 14:31:41 -0500,
Will Andrews wrote:
> On Fri, May 04, 2001 at 12:33:04PM -0700, Eric Melville wrote:
> > Is it also accepted policy to NOT hardcode -j options to make? If not, can
> > we make it so? This is just asking for trouble in many cases.
>
> Sure. I think it's probably useful to add a "MAKE_JOBS" variable to
> bsd.port.mk so people who know what they are doing can use it easily.
> Regardless, I agree 100% with you on the -j thing.
How about introducing a per-port boolean variable "MAKE_JOBS_SAFE"
along with "MAKE_JOBS" ? (Rename them if you could think of better
names)
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.366
diff -u -u -r1.366 bsd.port.mk
--- bsd.port.mk 2001/04/22 16:47:55 1.366
+++ bsd.port.mk 2001/05/04 21:04:18
@@ -404,6 +404,9 @@
# and install stages (default: see below).
# MAKE_ARGS - Any extra arguments to sub-make in build and install
# stages (default: none).
+# MAKE_JOBS - Specify the -jN option to be added to MAKE_ARGS when
+# MAKE_JOBS_SAFE is defined (default: -j4).
+# MAKE_JOBS_SAFE - Says that the port is safe to build with make -jN.
#
# For install:
#
@@ -748,6 +751,12 @@
SCRIPTS_ENV+= PORTOBJFORMAT=${PORTOBJFORMAT}
MAKE_ENV+= PORTOBJFORMAT=${PORTOBJFORMAT}
PLIST_SUB+= PORTOBJFORMAT=${PORTOBJFORMAT}
+
+MAKE_JOBS?= -j4
+
+.if defined(MAKE_JOBS_SAFE)
+MAKE_ARGS+= ${MAKE_JOBS}
+.endif
.if defined(MANCOMPRESSED)
.if ${MANCOMPRESSED} != yes && ${MANCOMPRESSED} != no && \
P.S.
Where do all those portmgr's belong? My patches against bsd.ruby.mk
have always been ignored...
--
/
/__ __ Akinori.org / MUSHA.org
/ ) ) ) ) / FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp
"Freeze this moment a little bit longer, make each impression
a little bit stronger.. Experience slips away -- Time stand still"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?863dakddpo.wl>