Date: Fri, 5 May 2006 19:28:42 +0400 From: "Andrew Pantyukhin" <infofarmer@gmail.com> To: "Ion-Mihai Tetcu" <itetcu@people.tecnik93.com> Cc: FreeBSD Ports <ports@freebsd.org>, Sam Lawrance <lawrance@freebsd.org> Subject: Re: sourceforge subdir default Message-ID: <cb5206420605050828x1eb45311g7b54cc6ee79eb6d2@mail.gmail.com> In-Reply-To: <20060505165738.1965f74f@it.buh.cameradicommercio.ro> References: <cb5206420602180112k135e0569o360f02aad4fd4b0b@mail.gmail.com> <127FEBDA-4446-47DB-B6CA-4AB6A5CE8562@FreeBSD.org> <cb5206420604270827r2c03fbacx9e391a3e9489398@mail.gmail.com> <20060428003008.19f61dbc@it.buh.tecnik93.com> <cb5206420605050650j71bb7c81scd2bdba0a80823ca@mail.gmail.com> <20060505165738.1965f74f@it.buh.cameradicommercio.ro>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/5/06, Ion-Mihai Tetcu <itetcu@people.tecnik93.com> wrote:
> On Fri, 5 May 2006 17:50:37 +0400
> "Andrew Pantyukhin" <infofarmer@gmail.com> wrote:
>
> > On 4/28/06, Ion-Mihai Tetcu <itetcu@people.tecnik93.com> wrote:
> > > On Thu, 27 Apr 2006 19:27:38 +0400
> > > "Andrew Pantyukhin" <infofarmer@gmail.com> wrote:
> > > > Okay, I wonder if we can set M_S_SUBDIR to PORTNAME
> > > > by default no matter what MASTER_SITES we have. I mean
> > > > if there's a %SUBDIR% to replace, PORTNAME seems to be
> > > > a reasonable default value, doesn't it?
> > >
> > > I've been thinking about the same thing for some time.
> > >
> > > Care to provide:
> > > a) patch for b.p.m
> > > b) patch for affected ports where this is true
> > > ( c) the rest of M_S_SF ports should work w/o modifications ) ?
> > >
> > > I'll do a test for all the affected ports.
> >
> > % find /usr/ports -iname Makefile\* -exec egrep -H
> > '^MASTER_SITE_SUBDIR=3D[[:space:]]*\$\{PORTNAME\}$' {} + | wc -l
> > 1357
> >
> > So I think I won't provide a patch for the ports, we'll do patching
> > step-by-step later (in the manner of USE_REINPLACE deprecation)
> >
> > Attached is a very simple diff. Even without any testing, I don't see
> > how it can break anything at all. I'll submit a pr some time later.
>
> I'll run a (partial) test tonight or tomorrow; first step would be to
> find for how many ports this default is true and if we shouldn't rather
> set a default for each MASTER_SITE_*
Since I have a free minute, I'll do this mega-research for
you.
There are 1372 makefiles in /usr/ports that match
'^MASTER_SITE_SUBDIR=3D[[:space:]]*\$\{PORTNAME\}$'
These don't include those where portname is spelled
explicitly (instead of ${PORTNAME})
1212 of these use SOURCEFORGE (1153 exclusively and
59 with other sites)
The rest is:
_GNU (with derivatives) - 53
_SAVANNAH - 39
_MOZDEV - 4
and others
34 of these ports use %SUBDIR% in custom URLs.
6676 ports use _SUBDIR macro. Over 20% can be simplified
after this patch is applied.
Mind you, it's not easy (read earlier in this thread) to define
SUBDIR default based on MASTER_SITE macro in use. If all
goes well, I'll work on a slightly more complicated patch
that will provide correct defaults for about 2000 p5 ports.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cb5206420605050828x1eb45311g7b54cc6ee79eb6d2>