Date: Wed, 17 Feb 2010 03:27:36 -0600 From: Scot Hetzel <swhetzel@gmail.com> To: jhell <jhell@dataix.net>, Bartosz Stec <bartosz.stec@it4pro.pl> Cc: freebsd-stable@freebsd.org Subject: Re: ZFS tuning [was: hardware for home use large storage] Message-ID: <790a9fff1002170127s153a6813p5e92055dc5d94ba2@mail.gmail.com> In-Reply-To: <4B7BAF59.7040407@it4pro.pl> References: <cf9b1ee01002150049o43fced71ucb5776a0a1eaf4cf@mail.gmail.com> <alpine.BSF.2.00.1002152024040.74553@pragry.qngnvk.ybpny> <4B7AD0A3.9080701@barryp.org> <20100216175946.GA98082@icarus.home.lan> <20100216200511.GA95812@server.vk2pj.dyndns.org> <20100216215637.GA4299@icarus.home.lan> <alpine.BSF.2.00.1002170241080.14189@pragry.qngnvk.ybpny> <4B7BA6A5.9020306@it4pro.pl> <20100217093237.fe4b4e14.torfinn.ingolfsen@broadpark.no> <4B7BAF59.7040407@it4pro.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--001636283dce02a68e047fc8769e
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On Wed, Feb 17, 2010 at 2:56 AM, Bartosz Stec <bartosz.stec@it4pro.pl> wrot=
e:
> On 2010-02-17 09:32, Torfinn Ingolfsen wrote:
>>
>> On Wed, 17 Feb 2010 09:19:49 +0100
>> Bartosz Stec<bartosz.stec@it4pro.pl> =A0wrote:
>>
>>
>>>
>>> So here's my reply (last line seems most interesting ;) :
>>>
>>
>> [...snipped...]
>>
>>>
>>> Illegal division by zero at ./arc_summary.pl line 242.
>>>
>>
>> FWIW, I also got this line when I ran this script on my idle zfs server.
>>
>
> I'm not a PERL programmer (or programmer at all ;), but what I see is scr=
ipt
> doesn't check if L2ARC is used at all, so it will always try compute thes=
e
> lines:
>
> printf("\tL2 Hit Ratio:\t\t\t%0.2f%%\t%d\n", 100 * ( $l2_hits / ( $l2_hit=
s +
> $l2_misses )), $l2_hits );
> printf("\tL2 Miss Ratio:\t\t\t%0.2f%%\t%d\n", 100 * ( $l2_misses / (
> $l2_hits + $l2_misses )), $l2_misses );
> printf("\tL2 Feeds Ratio:\t\t\t%0.2f%%\t%d\n", 100 * ( $l2_feeds / (
> $l2_hits + $l2_misses )), $l2_feeds );
>
> Without active L2ARC it will always generate divide at zeo error, so it
> seems that additional check for usable L2ARC values is needed at first
> place.
>
The attached patch fixes the divide by zero errors.
Scot
--001636283dce02a68e047fc8769e
Content-Type: application/octet-stream; name=patch1
Content-Disposition: attachment; filename=patch1
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g5rwz9800
LS0tIGFyY19zdW1tYXJ5LnBsLW9yaWcJMjAxMC0wMi0xNyAwNzozMDo0OS4wMDAwMDAwMDAgKzAw
MDAKKysrIGFyY19zdW1tYXJ5LnBsCTIwMTAtMDItMTcgMDM6MTA6MzEuODA4OTYwNjM1ICswMDAw
CkBAIC0yMTAsNiArMjEwLDcgQEAKICMjIyMgTDIgQVJDIFN0YXRzIFN5c2N0bCdzICMjIyMjIyMj
IyMjIyMKIG15ICRsMl9oaXRzID0gJHtLc3RhdH0tPnt6ZnN9LT57MH0tPnthcmNzdGF0c30tPnts
Ml9oaXRzfTsgIyB1c2VkCiBteSAkbDJfbWlzc2VzID0gJHtLc3RhdH0tPnt6ZnN9LT57MH0tPnth
cmNzdGF0c30tPntsMl9taXNzZXN9OyAjIHVzZWQKK215ICRsMl9oaXRzX21pc3NlcyA9ICRsMl9o
aXRzICsgJGwyX21pc3NlczsgIyB1c2VkCiBteSAkbDJfZmVlZHMgPSAke0tzdGF0fS0+e3pmc30t
PnswfS0+e2FyY3N0YXRzfS0+e2wyX2ZlZWRzfTsgIyB1c2VkCiBteSAkbDJfcndfY2xhc2ggPSAk
e0tzdGF0fS0+e3pmc30tPnswfS0+e2FyY3N0YXRzfS0+e2wyX3J3X2NsYXNofTsKIG15ICRsMl93
cml0ZXNfc2VudCA9ICR7S3N0YXR9LT57emZzfS0+ezB9LT57YXJjc3RhdHN9LT57bDJfd3JpdGVz
X3NlbnR9OyAjIHVzZWQKQEAgLTIzOCwxOCArMjM5LDM4IEBACiBwcmludCAiXG4iOwogCiBwcmlu
dCAiTDIgQVJDIEJyZWFrZG93bjpcbiI7Ci1wcmludGYoIlx0TDIgQWNjZXNzIFRvdGFsOlx0XHRc
dCVkXG4iLCAoICRsMl9oaXRzICsgJGwyX21pc3NlcyApICk7Ci1wcmludGYoIlx0TDIgSGl0IFJh
dGlvOlx0XHRcdCUwLjJmJSVcdCVkXG4iLCAxMDAgKiAoICRsMl9oaXRzIC8gKCAkbDJfaGl0cyAr
ICRsMl9taXNzZXMgKSksICRsMl9oaXRzICk7Ci1wcmludGYoIlx0TDIgTWlzcyBSYXRpbzpcdFx0
XHQlMC4yZiUlXHQlZFxuIiwgMTAwICogKCAkbDJfbWlzc2VzIC8gKCAkbDJfaGl0cyArICRsMl9t
aXNzZXMgKSksICRsMl9taXNzZXMgKTsKLXByaW50ZigiXHRMMiBGZWVkcyBSYXRpbzpcdFx0XHQl
MC4yZiUlXHQlZFxuIiwgMTAwICogKCAkbDJfZmVlZHMgLyAoICRsMl9oaXRzICsgJGwyX21pc3Nl
cyApKSwgJGwyX2ZlZWRzICk7CitwcmludGYoIlx0TDIgQWNjZXNzIFRvdGFsOlx0XHRcdCVkXG4i
LCAoICRsMl9oaXRzX21pc3NlcyApICk7CitpZiAoICRsMl9oaXRzX21pc3NlcyA+IDApIHsKKwlw
cmludGYoIlx0TDIgSGl0IFJhdGlvOlx0XHRcdCUwLjJmJSVcdCVkXG4iLCAxMDAgKiAoICRsMl9o
aXRzIC8gKCAkbDJfaGl0c19taXNzZXMgKSksICRsMl9oaXRzICk7CisJcHJpbnRmKCJcdEwyIE1p
c3MgUmF0aW86XHRcdFx0JTAuMmYlJVx0JWRcbiIsIDEwMCAqICggJGwyX21pc3NlcyAvICggJGwy
X2hpdHNfbWlzc2VzICkpLCAkbDJfbWlzc2VzICk7CisJcHJpbnRmKCJcdEwyIEZlZWRzIFJhdGlv
Olx0XHRcdCUwLjJmJSVcdCVkXG4iLCAxMDAgKiAoICRsMl9mZWVkcyAvICggJGwyX2hpdHNfbWlz
c2VzICkpLCAkbDJfZmVlZHMgKTsKK30gZWxzZSB7CisJcHJpbnRmKCJcdEwyIEhpdCBSYXRpbzpc
dFx0XHRVbmtub3duXHQlZFxuIiwgJGwyX2hpdHMgKTsKKwlwcmludGYoIlx0TDIgTWlzcyBSYXRp
bzpcdFx0XHRVbmtub3duXHQlZFxuIiwgJGwyX21pc3NlcyApOworCXByaW50ZigiXHRMMiBGZWVk
cyBSYXRpbzpcdFx0XHRVbmtub3duXHQlZFxuIiwgICRsMl9mZWVkcyApOworfQogcHJpbnQgIlxu
IjsKIAotcHJpbnRmKCAiXHRMMiBSZWFkczpcdFx0XHQlMC4yZiUlXHQlZFxuIiwgMTAwICogKCgg
JGwyX2hpdHMgKyAkbDJfbWlzc2VzIC0gJGwyX3dyaXRlc19zZW50ICkgLyAoICRsMl9oaXRzICsg
JGwyX21pc3NlcyApKSwgKCAkbDJfaGl0cyArICRsMl9taXNzZXMgLSAkbDJfd3JpdGVzX3NlbnQg
KSk7CitpZiAoICRsMl9oaXRzX21pc3NlcyA+IDApIHsKKwlwcmludGYoICJcdEwyIFJlYWRzOlx0
XHRcdCUwLjJmJSVcdCVkXG4iLCAxMDAgKiAoKCAkbDJfaGl0c19taXNzZXMgLSAkbDJfd3JpdGVz
X3NlbnQgKSAvICggJGwyX2hpdHNfbWlzc2VzICkpLCAoICRsMl9oaXRzX21pc3NlcyAtICRsMl93
cml0ZXNfc2VudCApKTsKK30gZWxzZSB7CisJIHByaW50ZiggIlx0TDIgUmVhZHM6XHRcdFx0VW5r
bm93blx0JWRcbiIsICggJGwyX2hpdHNfbWlzc2VzIC0gJGwyX3dyaXRlc19zZW50ICkpOworfQog
cHJpbnQgIlxuIjsKKwogcHJpbnQgIlx0TDIgV3JpdGVzOlxuIjsKLXByaW50ZigiXHQgIFNlbnQg
UmF0aW86XHRcdFx0JTAuMmYlJVx0JWRcbiIsIDEwMCAqICggJGwyX3dyaXRlc19zZW50IC8gKCRs
Ml9oaXRzICsgJGwyX21pc3NlcykpLCAkbDJfd3JpdGVzX3NlbnQgKTsKLXByaW50ZigiXHQgIERv
bmUgUmF0aW86XHRcdFx0JTAuMmYlJVx0JWRcbiIsIDEwMCAqICggJGwyX3dyaXRlc19kb25lIC8g
JGwyX3dyaXRlc19zZW50ICksICRsMl93cml0ZXNfZG9uZSApOwotcHJpbnRmKCJcdCAgRXJyb3Ig
UmF0aW86XHRcdFx0JTAuMmYlJVx0JWRcbiIsIDEwMCAqICggJGwyX3dyaXRlc19lcnJvciAvICRs
Ml93cml0ZXNfc2VudCApLCAkbDJfd3JpdGVzX2Vycm9yICk7CitpZiAoICRsMl9oaXRzX21pc3Nl
cyA+IDApIHsKKwlwcmludGYoIlx0ICBTZW50IFJhdGlvOlx0XHRcdCUwLjJmJSVcdCVkXG4iLCAx
MDAgKiAoICRsMl93cml0ZXNfc2VudCAvICgkbDJfaGl0c19taXNzZXMpKSwgJGwyX3dyaXRlc19z
ZW50ICk7Cit9IGVsc2UgeworCXByaW50ZigiXHQgIFNlbnQgUmF0aW86XHRcdFx0VW5rbm93blx0
JWRcbiIsICRsMl93cml0ZXNfc2VudCApOworfQoraWYgKCAkbDJfd3JpdGVzX3NlbnQgPiAwKSB7
CisJcHJpbnRmKCJcdCAgRG9uZSBSYXRpbzpcdFx0XHQlMC4yZiUlXHQlZFxuIiwgMTAwICogKCAk
bDJfd3JpdGVzX2RvbmUgLyAkbDJfd3JpdGVzX3NlbnQgKSwgJGwyX3dyaXRlc19kb25lICk7CisJ
cHJpbnRmKCJcdCAgRXJyb3IgUmF0aW86XHRcdFx0JTAuMmYlJVx0JWRcbiIsIDEwMCAqICggJGwy
X3dyaXRlc19lcnJvciAvICRsMl93cml0ZXNfc2VudCApLCAkbDJfd3JpdGVzX2Vycm9yICk7Cit9
IGVsc2UgeworCXByaW50ZigiXHQgIERvbmUgUmF0aW86XHRcdFx0VW5rbm93blx0JWRcbiIsICRs
Ml93cml0ZXNfZG9uZSApOworCXByaW50ZigiXHQgIEVycm9yIFJhdGlvOlx0XHRcdFVua25vd25c
dCVkXG4iLCAkbDJfd3JpdGVzX2Vycm9yICk7Cit9CiBwcmludCAiXG5cbiI7CiAKICMjIyMgVHVu
YWJsZXMgIyMjIyMjIyMjIyMjIyMjIyMjIyMjCg==
--001636283dce02a68e047fc8769e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?790a9fff1002170127s153a6813p5e92055dc5d94ba2>