Date: Thu, 27 May 2004 11:57:36 -0700 (PDT) From: Nate Lawson <nate@root.org> To: "Liam J. Foy" <liamfoy@sepulcrum.org> Cc: freebsd-acpi@freebsd.org Subject: Re: APM Patch - review Message-ID: <20040527115655.M92394@root.org> In-Reply-To: <20040527074654.73d5ec7d.liamfoy@sepulcrum.org> References: <F760B14C9561B941B89469F59BA3A8470647F8A8@orsmsx401.amr.corp.intel.com> <20040527074654.73d5ec7d.liamfoy@sepulcrum.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 May 2004, Liam J. Foy wrote: > On Wed, 26 May 2004 22:08:26 -0700 (PDT) > Nate Lawson <nate@root.org> wrote: > > > On Tue, 25 May 2004, Grover, Andrew wrote: > > > Valid values for remaining battery life are 0xFF, and 0-100. > > > > > > -1, 255 and 0xFF are the SAME when looking at an 8 bit value. Since this > > > 8 bit value was sign-extended to 32 bits to go into ai_batt_time, if it > > > was 0xFF, it is now 0xFFFFFFFF, and you will never see 0x000000FF. > > > > Correct. Liam, can you add a printf for the unknown case (%x) that gives > > the actual value? > > Nate, to do you mean add a printf to the unknown case to print the value instead > of have "invalud value (%x)" etc? Oh, I missed that part where you said you get "-1" printed for the "invalid value (%x) case. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040527115655.M92394>