Date: Tue, 8 Jan 2013 17:10:07 +0000 From: Max Brazhnikov <makc@freebsd.org> To: Wesley Shields <wxs@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, g.veniamin@googlemail.com, ports-committers@freebsd.org Subject: Re: svn commit: r310095 - in head/audio/clementine-player: . files Message-ID: <201301081710.08386.makc@freebsd.org> In-Reply-To: <201301081618.r08GIG15022688@svn.freebsd.org> References: <201301081618.r08GIG15022688@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
Considering that dbus is required for other options (DEVICEKIT, MTP) I'd make
dbus dependency non-optional (as it was before this update).
Cheers,
Max
On Tue, 8 Jan 2013 16:18:16 +0000 (UTC)Tue Jan 8 16:18:15 2013, Wesley Shields wrote:
> +OPTIONS_DEFAULTS= AUDIOCD DBUS DEVICEKIT GIO GOOGLE_DRIVE LASTFM MTP SPOTIFY \
> + VISUALISATION WIIMOTEDEV
> +
> +.include <bsd.port.options.mk>
> +
> +.if ${PORT_OPTIONS:MAUDIOCD}
> +CMAKE_ARGS+= -DENABLE_AUDIOCD=ON
> +LIB_DEPENDS+= cdio:${PORTSDIR}/sysutils/libcdio
> +.else
> +CMAKE_ARGS+= -DENABLE_AUDIOCD=OFF
> +.endif
>
> -.if defined(WITH_VISUALISATION)
> -PLIST_SUB+= VSL=""
> +.if ${PORT_OPTIONS:MBREAKPAD}
> +CMAKE_ARGS+= -DENABLE_BREAKPAD=ON
> .else
> -CMAKE_ARGS+= -DENABLE_VISUALISATIONS=OFF
> -PLIST_SUB+= VSL="@comment "
> +CMAKE_ARGS+= -DENABLE_BREAKPAD=OFF
> +.endif
> +
> +.if ${PORT_OPTIONS:MDBUS}
> +CMAKE_ARGS+= -DENABLE_DBUS=ON
> +USE_QT4+= dbus
> +.else
> +CMAKE_ARGS+= -DENABLE_DBUS=OFF
> +.endif
> +
> +.if ${PORT_OPTIONS:MDEVICEKIT}
> +CMAKE_ARGS+= -DENABLE_DEVICEKIT=ON
> +USE_QT4+= dbus
> +.else
> +CMAKE_ARGS+= -DENABLE_DEVICEKIT=OFF
> +.endif
> +
> +.if ${PORT_OPTIONS:MGIO}
> +CMAKE_ARGS+= -DENABLE_GIO=ON
> +USE_GNOME= glib20
> +.else
> +CMAKE_ARGS+= -DENABLE_GIO=OFF
> +.endif
> +
> +.if ${PORT_OPTIONS:MGOOGLE_DRIVE}
> +CMAKE_ARGS+= -DENABLE_GOOGLE_DRIVE=ON
> +BUILD_DEPENDS+= ${LOCALBASE}/include/google/sparsehash/sparseconfig.h:${PORTSDIR}/devel/google-sparsehash
> +.else
> +CMAKE_ARGS+= -DENABLE_GOOGLE_DRIVE=OFF
> +.endif
> +
> +.if ${PORT_OPTIONS:MGPOD}
> +CMAKE_ARGS+= -DENABLE_LIBGPOD=ON
> +LIB_DEPENDS+= gpod:${PORTSDIR}/audio/libgpod
> +.else
> +CMAKE_ARGS+= -DENABLE_LIBGPOD=OFF
> +.endif
> +
> +.if ${PORT_OPTIONS:MIMOBILEDEVICE}
> +CMAKE_ARGS+= -DENABLE_IMOBILEDEVICE=ON
> +LIB_DEPENDS+= imobiledevice:${PORTSDIR}/comms/libimobiledevice \
> + plist:${PORTSDIR}/devel/libplist \
> + usbmuxd:${PORTSDIR}/comms/usbmuxd
> +.else
> +CMAKE_ARGS+= -DENABLE_IMOBILEDEVICE=OFF
> +.endif
> +
> +.if ${PORT_OPTIONS:MLASTFM}
> +CMAKE_ARGS+= -DENABLE_LIBLASTFM=ON
> +LIB_DEPENDS+= lastfm:${PORTSDIR}/audio/liblastfm
> +.else
> +CMAKE_ARGS+= -DENABLE_LIBLASTFM=OFF
> +.endif
> +
> +.if ${PORT_OPTIONS:MMTP}
> +CMAKE_ARGS+= -DENABLE_LIBMTP=ON
> +LIB_DEPENDS+= mtp:${PORTSDIR}/audio/libmtp
> +.else
> +CMAKE_ARGS+= -DENABLE_LIBMTP=OFF
> .endif
>
> -.if defined(WITH_LASTFM)
> -LIB_DEPENDS+= lastfm.0:${PORTSDIR}/audio/liblastfm
> +.if ${PORT_OPTIONS:MSPOTIFY}
> +CMAKE_ARGS+= -DENABLE_SPOTIFY=ON
> .else
> -CMAKE_ARGS+= -DENABLE_LIBLASTFM=Off
> +CMAKE_ARGS+= -DENABLE_SPOTIFY=OFF
> .endif
>
> -.if defined(WITH_GPOD)
> -LIB_DEPENDS+= gpod.7:${PORTSDIR}/audio/libgpod
> +.if ${PORT_OPTIONS:MVISUALISATION}
> +CMAKE_ARGS+= -DENABLE_VISUALISATIONS=ON
> +PLIST_SUB+= VSL=""
> .else
> -CMAKE_ARGS+= -DENABLE_LIBGPOD=Off
> +CMAKE_ARGS+= -DENABLE_VISUALISATIONS=OFF
> +PLIST_SUB+= VSL="@comment "
> .endif
>
> -.if defined(WITH_MTP)
> -LIB_DEPENDS+= mtp.9:${PORTSDIR}/audio/libmtp
> +.if ${PORT_OPTIONS:MWIIMOTEDEV}
> +CMAKE_ARGS+= -DENABLE_WIIMOTEDEV=ON
> +USE_QT4+= dbus
> .else
> -CMAKE_ARGS+= -DENABLE_LIBMTP=Off
> +CMAKE_ARGS+= -DENABLE_WIIMOTEDEV=OFF
> .endif
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301081710.08386.makc>